-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Android build failure no member named 'StatusName' in namespace '… #24610
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Followup_24387_1
Jan 24, 2023
Merged
Fix Android build failure no member named 'StatusName' in namespace '… #24610
bzbarsky-apple
merged 1 commit into
project-chip:master
from
vivien-apple:Followup_24387_1
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13 and
harimau-qirex
January 24, 2023 09:41
pullapprove
bot
requested review from
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 24, 2023 09:41
vivien-apple
force-pushed
the
Followup_24387_1
branch
from
January 24, 2023 10:04
06b67d6
to
6befc84
Compare
…chip::Protocols::InteractionModel'
vivien-apple
force-pushed
the
Followup_24387_1
branch
from
January 24, 2023 10:10
6befc84
to
b84a1b3
Compare
PR #24610: Size comparison from d15be4c to b84a1b3 Increases (7 builds for bl602, cc13x2_26x2, linux, psoc6, telink)
Decreases (9 builds for cc13x2_26x2, linux, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Damian-Nordic
approved these changes
Jan 24, 2023
bzbarsky-apple
approved these changes
Jan 24, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…chip::Protocols::InteractionModel' (project-chip#24610)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…chip::Protocols::InteractionModel'
Problem
Android full builds fails on master because
CHIP_CONFIG_IM_STATUS_CODE_VERBOSE_FORMAT
is not enabled on Android platform. This PR fix that using an #ifdef and shuffle a little bit the code to address the comment #24387 (comment) and partially #24387 (comment)