[chip-tool] Add DataModelLogger::LogJson command and makes it goes ov… #24387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
force-pushed
the
ChipTool_SendBackResultsOverWebsockets
branch
from
8d2d905 to
5dab8a1
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google and
mrjerryjohns
|
PR #24387: Size comparison from 3670731 to 5dab8a1 Increases (11 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (10 builds for bl702, cc13x2_26x2, esp32, qpg, telink)
Full report (41 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
ChipTool_SendBackResultsOverWebsockets
branch
from
5dab8a1 to
f8f20c2
Compare
|
PR #24387: Size comparison from 2a55f23 to f8f20c2 Increases above 0.2%:
Increases (12 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, qpg, telink)
Decreases (5 builds for bl702, cc13x2_26x2, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 14, 2023
examples/chip-tool/commands/interactive/InteractiveCommands.cpp
Outdated
Show resolved
Hide resolved
vivien-apple
force-pushed
the
ChipTool_SendBackResultsOverWebsockets
branch
3 times, most recently
from
e19335f to
58ee4da
Compare
|
PR #24387: Size comparison from 9fbcf1c to 58ee4da Increases above 0.2%:
Increases (6 builds for bl602, linux, telink)
Decreases (6 builds for bl602, esp32, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
ChipTool_SendBackResultsOverWebsockets
branch
from
58ee4da to
8bf626f
Compare
|
PR #24387: Size comparison from 9fbcf1c to 8bf626f Increases above 0.2%:
Increases (13 builds for bl602, bl702, cc13x2_26x2, linux, psoc6, telink)
Decreases (9 builds for bl602, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
force-pushed
the
ChipTool_SendBackResultsOverWebsockets
branch
from
8bf626f to
5b27241
Compare
|
PR #24387: Size comparison from 59ab3ad to 5b27241 Increases above 0.2%:
Increases (11 builds for cc13x2_26x2, cyw30739, esp32, linux, psoc6, qpg, telink)
Decreases (6 builds for bl602, cc13x2_26x2, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Jan 23, 2023
vivien-apple
force-pushed
the
ChipTool_SendBackResultsOverWebsockets
branch
from
5b27241 to
4c1188f
Compare
andy31415
reviewed
Jan 23, 2023
andy31415
reviewed
Jan 23, 2023
andy31415
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Added an advance checkmark.
Offline chat with @vivien-apple that some (or all) of the comments may be addressed as followup - please create issues if that is the case and close the comment.
…er websockets in interactive server mode
vivien-apple
force-pushed
the
ChipTool_SendBackResultsOverWebsockets
branch
from
4c1188f to
eb5a48b
Compare
|
PR #24387: Size comparison from fc4281c to eb5a48b Increases above 0.2%:
Increases (9 builds for bl702, cc13x2_26x2, esp32, linux, telink)
Decreases (10 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…er websockets in interactive server mode (project-chip#24387)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…er websockets in interactive server mode
Problem
This PR sends some data back from
chip-toolto a web socket client.It both sends the command results as well as any logs dumped by the stack using the
ChipLog*helpers.I expect the
DataModelLogger::Log*changes to be temporary and changed in a different way in the future. The fundamental reason why I would like to changed that is because this not going to work withdarwin-framework-toolas if and I will have to duplicates some code. But in the meantime, it allows moving forward the python runner...