-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] Added door lock support for esp32. #24547
Merged
andy31415
merged 9 commits into
project-chip:master
from
jadhavrohit924:bugfix/door_lock_support
Jan 20, 2023
Merged
[ESP32] Added door lock support for esp32. #24547
andy31415
merged 9 commits into
project-chip:master
from
jadhavrohit924:bugfix/door_lock_support
Jan 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
door-lock code to common
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248 and
jelderton
January 20, 2023 07:09
pullapprove
bot
requested review from
mrjerryjohns,
msandstedt,
mspang,
pjzander-signify,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yufengwangca
January 20, 2023 07:09
PR #24547: Size comparison from cbc8fc4 to 03cca9c Increases above 0.2%:
Increases (10 builds for bl702, esp32, nrfconnect, psoc6, telink)
Decreases (9 builds for bl602, esp32, psoc6, qpg, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Jan 20, 2023
approved as a re-roll of the previous rollback in #24531 |
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jan 24, 2023
This is the regression from project-chip#24547, which is accessing the attributes even before Server is ready. Moved the lock initialization after service is initialized
shubhamdp
added a commit
to shubhamdp/connectedhomeip
that referenced
this pull request
Jan 24, 2023
This is the regression from project-chip#24547, which is accessing the attributes even before Server is ready. Moved the lock initialization after service is initialized
Damian-Nordic
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Fix the boot loop crash on M5Stack This is the regression from #24547, which is accessing the attributes even before Server is ready. Moved the lock initialization after service is initialized * Fix the typo for chip error format
lucicop
pushed a commit
that referenced
this pull request
Jan 24, 2023
* Fix the boot loop crash on M5Stack This is the regression from #24547, which is accessing the attributes even before Server is ready. Moved the lock initialization after service is initialized * Fix the typo for chip error format
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* [ESP32/Linux] Added support of door-lock for esp32 and moved linux door-lock code to common * Restored linux implementation, implemented door lock support for esp32 * Restyled by clang-format * esp32/all-clusters-app's uses linux door-lock replace it with esp32 door-lock support * Restyled by whitespace * Restyled by clang-format * Removed redundent handling of lock/unlock * Rebased and fixed zap generated changes * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Fix the boot loop crash on M5Stack This is the regression from project-chip#24547, which is accessing the attributes even before Server is ready. Moved the lock initialization after service is initialized * Fix the typo for chip error format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Changes
Testing