[tlv] Implemented Getter for Localized String Identifier #24528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang and
pjzander-signify
tcarmelveilleux
approved these changes
Jan 19, 2023
yufengwangca
approved these changes
Jan 19, 2023
|
PR #24528: Size comparison from a722c18 to a86ea4b Increases (8 builds for bl702, cc13x2_26x2, psoc6, telink)
Decreases (10 builds for bl602, bl702, cc13x2_26x2, linux, qpg, telink)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, nrfconnect, psoc6, qpg, telink)
|
|
PR #24528: Size comparison from a722c18 to e8eaf18 Increases (7 builds for bl602, bl702, psoc6)
Decreases (8 builds for bl602, linux, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #24528: Size comparison from a722c18 to aa1897d Increases (9 builds for bl702, cc13x2_26x2, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, linux, nrfconnect, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cliffamzn
reviewed
Jan 20, 2023
swan-amazon
reviewed
Jan 20, 2023
emargolis
force-pushed
the
emargolis/feature/tlv-reader-implement-localized-str-id-getter
branch
from
aa1897d to
7714365
Compare
New method TLVReader::Get(Optional<LocalizedStringIdentifier>&) returns Localized String Identifier if present. The method takes what's after the first Information Separator 1 <IS1>, and until end of string or second <IS1>, and return the hex-decoded string identifier, if one was there.
emargolis
force-pushed
the
emargolis/feature/tlv-reader-implement-localized-str-id-getter
branch
from
7714365 to
cb81cfb
Compare
bzbarsky-apple
approved these changes
Jan 21, 2023
|
PR #24528: Size comparison from 28778b8 to cb81cfb Increases (11 builds for bl702, cyw30739, psoc6, telink)
Decreases (12 builds for bl602, esp32, linux, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
- buffer underrun error: happens when encoded tlv data buffer length is shorter than needed. - wrong tlv type error, happens when bytestring is encoded while utf-8 string was expected.
Co-authored-by: Karsten Sperling <[email protected]>
Co-authored-by: Karsten Sperling <[email protected]>
Co-authored-by: Karsten Sperling <[email protected]>
|
PR #24528: Size comparison from 28778b8 to b71fc03 Increases above 0.2%:
Increases (15 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg)
Decreases (2 builds for bl702)
Full report (15 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg)
|
|
PR #24528: Size comparison from 28778b8 to 735d2e5 Increases (4 builds for mbed, nrfconnect)
Full report (4 builds for mbed, nrfconnect)
|
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…p#24528) * [tlv] Implemented Getter for Localized String Identifier New method TLVReader::Get(Optional<LocalizedStringIdentifier>&) returns Localized String Identifier if present. The method takes what's after the first Information Separator 1 <IS1>, and until end of string or second <IS1>, and return the hex-decoded string identifier, if one was there. * Added two error test cases: - buffer underrun error: happens when encoded tlv data buffer length is shorter than needed. - wrong tlv type error, happens when bytestring is encoded while utf-8 string was expected. * Update src/lib/core/TLVReader.h Co-authored-by: Karsten Sperling <[email protected]> * Update src/lib/core/TLVReader.cpp Co-authored-by: Karsten Sperling <[email protected]> * Update src/lib/core/TLVReader.cpp Co-authored-by: Karsten Sperling <[email protected]> * Added check for leading zeroes in the Localized String Identifier. Co-authored-by: Karsten Sperling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New method TLVReader::Get(Optional&) returns Localized String Identifier if present.
The method takes what's after the first Information Separator 1 , and until end of string or second , and return the hex-decoded string identifier, if one was there.
Fixes #24500