Enforce interface match for unauthenticated session, temporary fix #1…

…1120 (#11276) * Enforce interface match for unauthenticated session, temporary fix #11120 * Update src/transport/UnauthenticatedSessionTable.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
project-chip · Sep 2, 2022 · 2471490 · 2471490
1 parent 43d44f3
commit 2471490
Showing 1 changed file with 18 additions and 1 deletion.
diff --git a/src/transport/UnauthenticatedSessionTable.h b/src/transport/UnauthenticatedSessionTable.h
@@ -175,6 +175,21 @@ class UnauthenticatedSessionTable
         return result;
     }
 
+    // A temporary solution for #11120
+    // Enforce interface match if not null
+    static bool MatchInterface(Inet::InterfaceId i1, Inet::InterfaceId i2)
+    {
+        if (i1.IsPresent() && i2.IsPresent())
+        {
+            return i1 == i2;
+        }
+        else
+        {
+            // One of the interfaces is null.
+            return true;
+        }
+    }
+
     static bool MatchPeerAddress(const PeerAddress & a1, const PeerAddress & a2)
     {
         if (a1.GetTransportType() != a2.GetTransportType())
@@ -188,7 +203,9 @@ class UnauthenticatedSessionTable
         case Transport::Type::kTcp:
             return a1.GetIPAddress() == a2.GetIPAddress() && a1.GetPort() == a2.GetPort() &&
                 // Enforce interface equal-ness if the address is link-local, otherwise ignore interface
-                (a1.GetIPAddress().IsIPv6LinkLocal() ? a1.GetInterface() == a2.GetInterface() : true);
+                // Use MatchInterface for a temporary solution for #11120
+                (a1.GetIPAddress().IsIPv6LinkLocal() ? a1.GetInterface() == a2.GetInterface()
+                                                     : MatchInterface(a1.GetInterface(), a2.GetInterface()));
         case Transport::Type::kBle:
             // TODO: complete BLE address comparation
             return true;