Enforce interface match for unauthenticated session, temporary fix #11120 #11276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kghost
force-pushed
the
session-matching
branch
from
4ee6f71 to
8f5532f
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
balducci-apple,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chulspro,
Damian-Nordic,
electrocucaracha,
franck-apple,
harimau-qirex,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
pan-apple,
robszewczyk,
sagar-apple and
saurabhst
pullapprove
bot
requested review from
tcarmelveilleux,
tecimovic,
vivien-apple,
wbschiller,
woody-apple,
yufengwangca and
yunhanw-google
|
PR #11276: Size comparison from 79ba23d to 8f5532f Increases (23 builds for efr32, linux, nrfconnect, p6, telink)
Full report (35 builds for efr32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
msandstedt
approved these changes
Nov 1, 2021
bzbarsky-apple
approved these changes
Nov 1, 2021
Co-authored-by: Boris Zbarsky <[email protected]>
|
PR #11276: Size comparison from 79ba23d to 1266f2e Decreases (34 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
Full report (37 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
woody-apple
approved these changes
Nov 2, 2021
jmeg-sfy
approved these changes
Nov 3, 2021
andy31415
approved these changes
Nov 3, 2021
andy31415
pushed a commit
that referenced
this pull request
Nov 3, 2021
…1120 (#11276) * Enforce interface match for unauthenticated session, temporary fix #11120 * Update src/transport/UnauthenticatedSessionTable.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
andy31415
pushed a commit
that referenced
this pull request
Nov 3, 2021
…1120 (#11276) * Enforce interface match for unauthenticated session, temporary fix #11120 * Update src/transport/UnauthenticatedSessionTable.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
|
TE6 cherrypicks are closed, however I cherrypicked into TE6 LTS branch |
pankore
pushed a commit
to pankore/connectedhomeip
that referenced
this pull request
Nov 24, 2021
…oject-chip#11120 (project-chip#11276) * Enforce interface match for unauthenticated session, temporary fix project-chip#11120 * Update src/transport/UnauthenticatedSessionTable.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
…oject-chip#11120 (project-chip#11276) * Enforce interface match for unauthenticated session, temporary fix project-chip#11120 * Update src/transport/UnauthenticatedSessionTable.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#11120
Change overview
Ensure that interface should match when matching unauthenticated session, if the interface is not null
Testing
Verified by unit-tests
Verified by scripts/tests/test_suites.sh
Haven't observed error in #11120, but have observed several mDNS discovery timeout error. It is probably unrelated to this PR.