Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Attestation trust store bridge #24381

Closed
wants to merge 72 commits into from
Closed

[Android] Attestation trust store bridge #24381

wants to merge 72 commits into from

Conversation

panliming-tuya
Copy link
Contributor

@panliming-tuya panliming-tuya commented Jan 12, 2023 •
edited
Loading

#24297

We have to make sure not to break existing public API, only make it better. Right now, most Java clients just use the default Device Attestation Verifier and likely know what PAAs they want to trust (e.g. their own). If you are a fully general commissioner, you always need more customization anyway. That is why I was suggesting also bridging the attestation trust store.

Therefore, I implemented the attestation trust store bridge in Android.

Testing

  • Used Android chip-tool and verified the existing path still works
  • Tested locally with modified Android chip-tool that implements the new delegate.

panliming-tuya and others added 30 commits October 13, 2022 20:33
@panliming-tuya
[Android] Added mechanism to override device attestation failure base…
11b5724 
…d on client/user; Commissioner attestation delegate should be able to override success
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
ea40f1a
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
5ed16c0
@panliming-tuya
platform jar keep name of method parameters
d36248a
@restyled-commits @panliming-tuya
Restyled by whitespace
1c38401
@restyled-commits @panliming-tuya
Restyled by google-java-format
587ac5f
@restyled-commits @panliming-tuya
Restyled by clang-format
66bedd6
@restyled-commits @panliming-tuya
Restyled by gn
d9be2ba
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
afdf205
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
e8f0495
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
640ddbd
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
3c4f499
@panliming-tuya
fix copyright
48ce640
@panliming-tuya
Merge branch 'additional-verification-after-attestation' of https://g…
eb95edd 
…ithub.com/panliming-tuya/connectedhomeip into additional-verification-after-attestation
@panliming-tuya
fix and modify comments
5e8723b
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
79024b4
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
2270c9d
@panliming-tuya
Use setters instead of adding parameters to methods
47f079e
@panliming-tuya
fix NetworkCredentials NPE
27a3862
@panliming-tuya
Do not expose deviceController raw pointer
beb066a
@panliming-tuya
add sample
f9d3dd5
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
9e6a181
@panliming-tuya
Create AttestationTrustStoreBridge when we know we have PAA certs.
38b0c0c
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
0ee733e
@panliming-tuya
fix jni method
8481cde
@panliming-tuya
fix certs loss of scope and add some comments
e6211db
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
3bacfe3
@panliming-tuya
Merge branch 'master' into additional-verification-after-attestation
3b40467
@panliming-tuya
implement destructor
b26afb9
@panliming-tuya
fix destructor crash
27584d6
@panliming-tuya panliming-tuya marked this pull request as draft January 17, 2023 15:16
@panliming-tuya panliming-tuya marked this pull request as ready for review January 18, 2023 10:17
@github-actions
Copy link

github-actions bot commented Jan 18, 2023 •
edited
Loading

PR #24381: Size comparison from c5cb0dd to 454d160

Increases (7 builds for cc13x2_26x2, cyw30739, esp32, nrfconnect)
platform target config section c5cb0dd 454d160 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 174956 174964 8 0.0
lock-ftd LP_CC2652R7 (read/write) 175408 175416 8 0.0
pump-app LP_CC2652R7 (read only) 687815 687823 8 0.0
.text 596908 596916 8 0.0
cyw30739 ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549462 549470 8 0.0
.app_xip_area 431296 431304 8 0.0
esp32 all-clusters-app c3devkit (read only) 1221460 1221462 2 0.0
(read/write) 1787114 1787122 8 0.0
.flash.rodata 245624 245632 8 0.0
.flash.text 1221460 1221462 2 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 804420 804424 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 text 773816 773820 4 0.0
Decreases (12 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
platform target config section c5cb0dd 454d160 change % change
bl602 lighting-app bl602 (read/write) 1329454 1329446 -8 -0.0
.text 1016690 1016688 -2 -0.0
bl602+rpc .text 1047620 1047618 -2 -0.0
bl702 lighting-app bl702 (read/write) 1194463 1194447 -16 -0.0
.debug_info 39909709 39909707 -2 -0.0
.text 956594 956590 -4 -0.0
bl702+rpc .debug_info 44299589 44299588 -1 -0.0
.text 1033448 1033446 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676523 676515 -8 -0.0
.text 589252 589244 -8 -0.0
lock-ftd LP_CC2652R7 (read only) 673599 673591 -8 -0.0
.text 597104 597096 -8 -0.0
pump-app LP_CC2652R7 (read/write) 161928 161920 -8 -0.0
esp32 all-clusters-app m5stack (read/write) 560335 560331 -4 -0.0
.flash.rodata 311408 311404 -4 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 27337252 27337251 -1 -0.0
qpg lighting-app qpg6105+debug (read/write) 1147652 1147644 -8 -0.0
.text 594752 594744 -8 -0.0
telink contact-sensor-app tlsr9518adk80d text 581588 581586 -2 -0.0
thermostat tlsr9518adk80d text 596842 596838 -4 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section c5cb0dd 454d160 change % change
bl602 lighting-app bl602 (read/write) 1329454 1329446 -8 -0.0
.bss 86926 86926 0 0.0
.data 9576 9576 0 0.0
.text 1016690 1016688 -2 -0.0
bl602+rpc (read/write) 1374886 1374886 0 0.0
.bss 94966 94966 0 0.0
.data 9976 9976 0 0.0
.text 1047620 1047618 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1194463 1194447 -16 -0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1535738 1535738 0 0.0
.debug_aranges 132776 132776 0 0.0
.debug_frame 487392 487392 0 0.0
.debug_info 39909709 39909707 -2 -0.0
.debug_line 5228082 5228082 0 0.0
.debug_loc 3394165 3394165 0 0.0
.debug_ranges 372600 372600 0 0.0
.debug_str 3508448 3508448 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 115312 115312 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569492 569492 0 0.0
.symtab 172080 172080 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956594 956590 -4 -0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1286611 1286611 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1684199 1684199 0 0.0
.debug_aranges 140992 140992 0 0.0
.debug_frame 515056 515056 0 0.0
.debug_info 44299589 44299588 -1 -0.0
.debug_line 5625835 5625835 0 0.0
.debug_loc 3590087 3590087 0 0.0
.debug_ranges 396296 396296 0 0.0
.debug_str 3911584 3911584 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129808 129808 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 629943 629943 0 0.0
.symtab 190384 190384 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033448 1033446 -2 -0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676523 676515 -8 -0.0
(read/write) 174956 174964 8 0.0
.bss 81172 81172 0 0.0
.data 3380 3380 0 0.0
.rodata 86955 86955 0 0.0
.text 589252 589244 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640155 640155 0 0.0
(read/write) 157916 157916 0 0.0
.bss 80420 80420 0 0.0
.data 3380 3380 0 0.0
.rodata 77043 77043 0 0.0
.text 562792 562792 0 0.0
lock-ftd LP_CC2652R7 (read only) 673599 673591 -8 -0.0
(read/write) 175408 175416 8 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 76015 76015 0 0.0
.text 597104 597096 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 659539 659539 0 0.0
(read/write) 184732 184732 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 102443 102443 0 0.0
.text 556616 556616 0 0.0
pump-app LP_CC2652R7 (read only) 687815 687823 8 0.0
(read/write) 161928 161920 -8 -0.0
.bss 78756 78756 0 0.0
.data 3268 3268 0 0.0
.rodata 90423 90423 0 0.0
.text 596908 596916 8 0.0
pump-controller-app LP_CC2652R7 (read only) 671859 671859 0 0.0
(read/write) 177988 177988 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86139 86139 0 0.0
.text 585240 585240 0 0.0
shell LP_CC2652R7 (read only) 667754 667754 0 0.0
(read/write) 186052 186052 0 0.0
.bss 83500 83500 0 0.0
.data 3376 3376 0 0.0
.rodata 83690 83690 0 0.0
.text 583752 583752 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584770 584770 0 0.0
.app_xip_area 461116 461116 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588494 588494 0 0.0
.app_xip_area 459544 459544 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549462 549470 8 0.0
.app_xip_area 431296 431304 8 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 974124 974124 0 0.0
.bss 152172 152172 0 0.0
.data 2168 2168 0 0.0
.text 819764 819764 0 0.0
BRD4161A+rs911x (read/write) 1037272 1037272 0 0.0
.bss 186648 186648 0 0.0
.data 2012 2012 0 0.0
.text 848592 848592 0 0.0
BRD4187C (read/write) 1147940 1147940 0 0.0
.bss 138568 138568 0 0.0
.data 2516 2516 0 0.0
.text 982260 982260 0 0.0
lock-app BRD4161A+wf200 (read/write) 1066296 1066296 0 0.0
.bss 158184 158184 0 0.0
.data 2020 2020 0 0.0
.text 906068 906068 0 0.0
window-app BRD4187C (read/write) 1140624 1140624 0 0.0
.bss 139984 139984 0 0.0
.data 2540 2540 0 0.0
.text 973504 973504 0 0.0
esp32 all-clusters-app c3devkit (read only) 1221460 1221462 2 0.0
(read/write) 1787114 1787122 8 0.0
.dram0.bss 75832 75832 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 245624 245632 8 0.0
.flash.text 1221460 1221462 2 0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1235031 1235031 0 0.0
(read/write) 560335 560331 -4 -0.0
.dram0.bss 80984 80984 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 311408 311404 -4 -0.0
.flash.text 1229647 1229647 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 659868 659868 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 561620 561620 0 0.0
light k32w0+release (read/write) 671392 671392 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 591780 591780 0 0.0
lock k32w0+release (read/write) 631236 631236 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 550844 550844 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10900452 10900452 0 0.0
(read/write) 695608 695608 0 0.0
.bss 34168 34168 0 0.0
.data 3024 3024 0 0.0
.data.rel.ro 639104 639104 0 0.0
.dynamic 560 560 0 0.0
.got 14104 14104 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 568500 568500 0 0.0
.text 8684740 8684740 0 0.0
thermostat-no-ble arm64 (read only) 2478748 2478748 0 0.0
(read/write) 143016 143016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149832 149832 0 0.0
.text 2068320 2068320 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2461952 2461952 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1424596 1424596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1164352 1164352 0 0.0
bss 146748 146748 0 0.0
rodata 132976 132976 0 0.0
text 804420 804424 4 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1366008 1366008 0 0.0
bss 106048 106048 0 0.0
rodata 210460 210460 0 0.0
text 763664 763664 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1110196 1110196 0 0.0
bss 145947 145947 0 0.0
rodata 110260 110260 0 0.0
text 773816 773820 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842024 842024 0 0.0
(read/write) 1748748 1748748 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188656 188656 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1247580 1247580 0 0.0
.debug_aranges 111248 111248 0 0.0
.debug_frame 373544 373544 0 0.0
.debug_info 27337252 27337251 -1 -0.0
.debug_line 3754221 3754221 0 0.0
.debug_loc 3643942 3643942 0 0.0
.debug_ranges 356464 356464 0 0.0
.debug_str 3465398 3465398 0 0.0
.heap 842024 842024 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 576350 576350 0 0.0
.symtab 423872 423872 0 0.0
.text 1549040 1549040 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842784 842784 0 0.0
(read/write) 1690188 1690188 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187896 187896 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1233387 1233387 0 0.0
.debug_aranges 110512 110512 0 0.0
.debug_frame 375988 375988 0 0.0
.debug_info 26898820 26898820 0 0.0
.debug_line 3762994 3762994 0 0.0
.debug_loc 3627342 3627342 0 0.0
.debug_ranges 354432 354432 0 0.0
.debug_str 3450254 3450254 0 0.0
.heap 842784 842784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 536840 536840 0 0.0
.symtab 408832 408832 0 0.0
.text 1491240 1491240 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1608860 1608860 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1067780 1067780 0 0.0
.debug_aranges 102712 102712 0 0.0
.debug_frame 346320 346320 0 0.0
.debug_info 22361176 22361176 0 0.0
.debug_line 3328203 3328203 0 0.0
.debug_loc 3327504 3327504 0 0.0
.debug_ranges 318568 318568 0 0.0
.debug_str 3255792 3255792 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473145 473145 0 0.0
.symtab 377328 377328 0 0.0
.text 1418104 1418104 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1642908 1642908 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1069826 1069826 0 0.0
.debug_aranges 103096 103096 0 0.0
.debug_frame 348120 348120 0 0.0
.debug_info 22579581 22579581 0 0.0
.debug_line 3329298 3329298 0 0.0
.debug_loc 3349033 3349033 0 0.0
.debug_ranges 320424 320424 0 0.0
.debug_str 3271626 3271626 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 475862 475862 0 0.0
.symtab 379152 379152 0 0.0
.text 1447160 1447160 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147652 1147644 -8 -0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 594752 594744 -8 -0.0
lock-app qpg6105+debug (read/write) 1115012 1115012 0 0.0
.bss 96868 96868 0 0.0
.data 852 852 0 0.0
.text 562108 562108 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1026312 1026312 0 0.0
bss 98184 98184 0 0.0
text 689120 689120 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 964652 964652 0 0.0
bss 97368 97368 0 0.0
text 652412 652412 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867588 867588 0 0.0
bss 89524 89524 0 0.0
text 581588 581586 -2 -0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 883912 883912 0 0.0
bss 89616 89616 0 0.0
text 596066 596066 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 961884 961884 0 0.0
bss 97676 97676 0 0.0
text 661912 661912 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 897884 897884 0 0.0
bss 90568 90568 0 0.0
text 607308 607308 0 0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887152 887152 0 0.0
bss 91004 91004 0 0.0
text 596842 596838 -4 -0.0

@panliming-tuya panliming-tuya mentioned this pull request Jan 19, 2023
Closed
@github-actions
Copy link

github-actions bot commented Jan 19, 2023 •
edited
Loading

PR #24381: Size comparison from 36133b1 to 3ede0b5

Increases (3 builds for psoc6, telink)
platform target config section 36133b1 3ede0b5 change % change
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26885958 26885959 1 0.0
telink contact-sensor-app tlsr9518adk80d text 581720 581722 2 0.0
lighting-app tlsr9518adk80d (read/write) 962012 962020 8 0.0
text 662044 662046 2 0.0
Decreases (4 builds for bl602, esp32, telink)
platform target config section 36133b1 3ede0b5 change % change
bl602 lighting-app bl602 .text 1016758 1016756 -2 -0.0
esp32 all-clusters-app c3devkit (read only) 1220134 1220132 -2 -0.0
.flash.text 1220134 1220132 -2 -0.0
telink ota-requestor-app tlsr9518adk80d (read/write) 898020 898012 -8 -0.0
text 607442 607440 -2 -0.0
thermostat tlsr9518adk80d (read/write) 887288 887280 -8 -0.0
text 596976 596972 -4 -0.0
Full report (43 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 36133b1 3ede0b5 change % change
bl602 lighting-app bl602 (read/write) 1329518 1329518 0 0.0
.bss 86926 86926 0 0.0
.data 9576 9576 0 0.0
.text 1016758 1016756 -2 -0.0
bl602+rpc (read/write) 1374950 1374950 0 0.0
.bss 94966 94966 0 0.0
.data 9976 9976 0 0.0
.text 1047688 1047688 0 0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1194527 1194527 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 66590 66590 0 0.0
.bss_psram 30048 30048 0 0.0
.comment 48 48 0 0.0
.data 4048 4048 0 0.0
.debug_abbrev 1535738 1535738 0 0.0
.debug_aranges 132792 132792 0 0.0
.debug_frame 487452 487452 0 0.0
.debug_info 39910661 39910661 0 0.0
.debug_line 5228269 5228269 0 0.0
.debug_loc 3394487 3394487 0 0.0
.debug_ranges 372616 372616 0 0.0
.debug_str 3513242 3513242 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 115312 115312 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 569788 569788 0 0.0
.symtab 172112 172112 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956660 956660 0 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1286675 1286675 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 74622 74622 0 0.0
.bss_psram 30304 30304 0 0.0
.comment 48 48 0 0.0
.data 4600 4600 0 0.0
.debug_abbrev 1684199 1684199 0 0.0
.debug_aranges 141008 141008 0 0.0
.debug_frame 515116 515116 0 0.0
.debug_info 44300540 44300540 0 0.0
.debug_line 5626022 5626022 0 0.0
.debug_loc 3590462 3590462 0 0.0
.debug_ranges 396312 396312 0 0.0
.debug_str 3916390 3916390 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129808 129808 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 630239 630239 0 0.0
.symtab 190416 190416 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1033512 1033512 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 675795 675795 0 0.0
(read/write) 175668 175668 0 0.0
.bss 81156 81156 0 0.0
.data 3380 3380 0 0.0
.rodata 86923 86923 0 0.0
.text 588560 588560 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 639443 639443 0 0.0
(read/write) 157900 157900 0 0.0
.bss 80404 80404 0 0.0
.data 3380 3380 0 0.0
.rodata 77035 77035 0 0.0
.text 562084 562084 0 0.0
lock-ftd LP_CC2652R7 (read only) 673615 673615 0 0.0
(read/write) 175392 175392 0 0.0
.bss 78788 78788 0 0.0
.data 3304 3304 0 0.0
.rodata 76015 76015 0 0.0
.text 597120 597120 0 0.0
lock-mtd LP_CC2652R7 (read only) 659563 659563 0 0.0
(read/write) 184708 184708 0 0.0
.bss 74052 74052 0 0.0
.data 3304 3304 0 0.0
.rodata 102443 102443 0 0.0
.text 556640 556640 0 0.0
pump-app LP_CC2652R7 (read only) 686439 686439 0 0.0
(read/write) 163288 163288 0 0.0
.bss 78740 78740 0 0.0
.data 3268 3268 0 0.0
.rodata 90055 90055 0 0.0
.text 595904 595904 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671875 671875 0 0.0
(read/write) 177972 177972 0 0.0
.bss 78860 78860 0 0.0
.data 3292 3292 0 0.0
.rodata 86139 86139 0 0.0
.text 585256 585256 0 0.0
shell LP_CC2652R7 (read only) 667034 667034 0 0.0
(read/write) 186756 186756 0 0.0
.bss 83484 83484 0 0.0
.data 3376 3376 0 0.0
.rodata 83658 83658 0 0.0
.text 583060 583060 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 584786 584786 0 0.0
.app_xip_area 461132 461132 0 0.0
.bss 66112 66112 0 0.0
.data 728 728 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 588518 588518 0 0.0
.app_xip_area 459568 459568 0 0.0
.bss 71400 71400 0 0.0
.data 736 736 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 549486 549486 0 0.0
.app_xip_area 431320 431320 0 0.0
.bss 60664 60664 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rpc (read/write) 973416 973416 0 0.0
.bss 146840 146840 0 0.0
.data 2188 2188 0 0.0
.text 824364 824364 0 0.0
BRD4161A+rs911x (read/write) 1035664 1035664 0 0.0
.bss 181312 181312 0 0.0
.data 2032 2032 0 0.0
.text 852300 852300 0 0.0
BRD4187C (read/write) 1149668 1149668 0 0.0
.bss 133324 133324 0 0.0
.data 2536 2536 0 0.0
.text 989212 989212 0 0.0
lock-app BRD4161A+wf200 (read/write) 1064548 1064548 0 0.0
.bss 152848 152848 0 0.0
.data 2040 2040 0 0.0
.text 909640 909640 0 0.0
window-app BRD4187C (read/write) 1142368 1142368 0 0.0
.bss 134740 134740 0 0.0
.data 2560 2560 0 0.0
.text 980472 980472 0 0.0
esp32 all-clusters-app c3devkit (read only) 1220134 1220132 -2 -0.0
(read/write) 1786714 1786714 0 0.0
.dram0.bss 75816 75816 0 0.0
.dram0.data 13928 13928 0 0.0
.flash.rodata 245240 245240 0 0.0
.flash.text 1220134 1220132 -2 -0.0
.iram0.text 71188 71188 0 0.0
m5stack (read only) 1233995 1233995 0 0.0
(read/write) 559947 559947 0 0.0
.dram0.bss 80968 80968 0 0.0
.dram0.data 34224 34224 0 0.0
.flash.rodata 311036 311036 0 0.0
.flash.text 1228611 1228611 0 0.0
.iram0.text 124803 124803 0 0.0
k32w contact k32w0+release (read/write) 659884 659884 0 0.0
.bss 77032 77032 0 0.0
.data 2104 2104 0 0.0
.text 561636 561636 0 0.0
light k32w0+release (read/write) 671424 671424 0 0.0
.bss 74824 74824 0 0.0
.data 2060 2060 0 0.0
.text 591812 591812 0 0.0
lock k32w0+release (read/write) 631268 631268 0 0.0
.bss 75584 75584 0 0.0
.data 2080 2080 0 0.0
.text 550876 550876 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10877444 10877444 0 0.0
(read/write) 695576 695576 0 0.0
.bss 34168 34168 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 639104 639104 0 0.0
.dynamic 560 560 0 0.0
.got 14104 14104 0 0.0
.init 24 24 0 0.0
.init_array 200 200 0 0.0
.rodata 564100 564100 0 0.0
.text 8666260 8666260 0 0.0
thermostat-no-ble arm64 (read only) 2479116 2479116 0 0.0
(read/write) 143016 143016 0 0.0
.bss 55336 55336 0 0.0
.data 1816 1816 0 0.0
.data.rel.ro 76632 76632 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 149832 149832 0 0.0
.text 2068688 2068688 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2461952 2461952 0 0.0
.bss 214932 214932 0 0.0
.data 5872 5872 0 0.0
.text 1424596 1424596 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1162988 1162988 0 0.0
bss 146732 146732 0 0.0
rodata 132604 132604 0 0.0
text 803440 803440 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1364644 1364644 0 0.0
bss 106032 106032 0 0.0
rodata 210088 210088 0 0.0
text 762680 762680 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1108856 1108856 0 0.0
bss 145935 145935 0 0.0
rodata 109912 109912 0 0.0
text 772836 772836 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 842040 842040 0 0.0
(read/write) 1747236 1747236 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188640 188640 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1246903 1246903 0 0.0
.debug_aranges 111168 111168 0 0.0
.debug_frame 373320 373320 0 0.0
.debug_info 27324385 27324385 0 0.0
.debug_line 3753044 3753044 0 0.0
.debug_loc 3642380 3642380 0 0.0
.debug_ranges 356408 356408 0 0.0
.debug_str 3469948 3469948 0 0.0
.heap 842040 842040 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 574998 574998 0 0.0
.symtab 423104 423104 0 0.0
.text 1547544 1547544 0 0.0
.zero.table 8 8 0 0.0
text 0 0 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 842800 842800 0 0.0
(read/write) 1688700 1688700 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187888 187888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2656 2656 0 0.0
.debug_abbrev 1232710 1232710 0 0.0
.debug_aranges 110432 110432 0 0.0
.debug_frame 375764 375764 0 0.0
.debug_info 26885958 26885959 1 0.0
.debug_line 3761841 3761841 0 0.0
.debug_loc 3625780 3625780 0 0.0
.debug_ranges 354376 354376 0 0.0
.debug_str 3454754 3454754 0 0.0
.heap 842800 842800 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 535378 535378 0 0.0
.symtab 408064 408064 0 0.0
.text 1489768 1489768 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 850976 850976 0 0.0
(read/write) 1608924 1608924 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179912 179912 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1067780 1067780 0 0.0
.debug_aranges 102728 102728 0 0.0
.debug_frame 346380 346380 0 0.0
.debug_info 22362283 22362283 0 0.0
.debug_line 3328327 3328327 0 0.0
.debug_loc 3327789 3327789 0 0.0
.debug_ranges 318584 318584 0 0.0
.debug_str 3260586 3260586 0 0.0
.heap 850976 850976 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 473441 473441 0 0.0
.symtab 377392 377392 0 0.0
.text 1418168 1418168 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 845984 845984 0 0.0
(read/write) 1642956 1642956 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 184888 184888 0 0.0
.comment 200 200 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1069826 1069826 0 0.0
.debug_aranges 103112 103112 0 0.0
.debug_frame 348180 348180 0 0.0
.debug_info 2258069 2258069 0 0.0
.debug_line 3329434 3329434 0 0.0
.debug_loc 3349379 3349379 0 0.0
.debug_ranges 320440 320440 0 0.0
.debug_str 3277028 3277028 0 0.0
.heap 845984 845984 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476376 476376 0 0.0
.symtab 379216 379216 0 0.0
.text 1447208 1447208 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1147676 1147676 0 0.0
.bss 100348 100348 0 0.0
.data 840 840 0 0.0
.text 594776 594776 0 0.0
lock-app qpg6105+debug (read/write) 1115028 1115028 0 0.0
.bss 96868 96868 0 0.0
.data 852 852 0 0.0
.text 562124 562124 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1024600 1024600 0 0.0
bss 98168 98168 0 0.0
text 687808 687808 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 962968 962968 0 0.0
bss 97356 97356 0 0.0
text 651100 651100 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 867724 867724 0 0.0
bss 89524 89524 0 0.0
text 581720 581722 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 884048 884048 0 0.0
bss 89616 89616 0 0.0
text 596200 596200 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 962012 962020 8 0.0
bss 97676 97676 0 0.0
text 662044 662046 2 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898020 898012 -8 -0.0
bss 90568 90568 0 0.0
text 607442 607440 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 887288 887280 -8 -0.0
bss 91004 91004 0 0.0
text 596976 596972 -4 -0.0

@pullapprove pullapprove bot requested a review from amitnj January 25, 2023 19:24
@joonhaengHeo
Copy link
Contributor

If you register Operational Credential Callback even if you merge this code, Device Attestation is not expected to work due to the code below.

connectedhomeip/src/controller/java/CHIPDeviceController-JNI.cpp

Line 650 in e2e6095

if (useCallback)

Shouldn't a code similar to Darwin's code below be added?
#24371

@yufengwangca
Copy link
Contributor

@panliming-tuya

This PR has been pending for a while, could you provide me the ETA?. This API is requested and used only by our company, so it looks only our product is blocked, I can take this over if you could not find the bandwidth to complete this PR.

Our app currently use DeviceAttestationDelegate API to always skip the attestation if it fails, but we hope to switch to this API to use vendor certs to conduct the attestation.

@panliming-tuya
Copy link
Contributor Author

If you register Operational Credential Callback even if you merge this code, Device Attestation is not expected to work due to the code below.

connectedhomeip/src/controller/java/CHIPDeviceController-JNI.cpp

Line 650 in e2e6095

if (useCallback)

Shouldn't a code similar to Darwin's code below be added? #24371

Yes, you are right. But I think Darwin's code should be remove. DacOnlyPartialAttestationVerifier can be replaced by the current implementation.

@panliming-tuya
Copy link
Contributor Author

@panliming-tuya

This PR has been pending for a while, could you provide me the ETA?. This API is requested and used only by our company, so it looks only our product is blocked, I can take this over if you could not find the bandwidth to complete this PR.

Our app currently use DeviceAttestationDelegate API to always skip the attestation if it fails, but we hope to switch to this API to use vendor certs to conduct the attestation.

It would be great if you could take over, I'm rushing through our company's product launch.

@pullapprove pullapprove bot requested a review from nivi-apple February 27, 2023 08:53
@yufengwangca
Copy link
Contributor

@panliming-tuya
This PR has been pending for a while, could you provide me the ETA?. This API is requested and used only by our company, so it looks only our product is blocked, I can take this over if you could not find the bandwidth to complete this PR.
Our app currently use DeviceAttestationDelegate API to always skip the attestation if it fails, but we hope to switch to this API to use vendor certs to conduct the attestation.

It would be great if you could take over, I'm rushing through our company's product launch.

No worry, I will take care of this.

@yufengwangca yufengwangca mentioned this pull request Mar 4, 2023
Merged
@yufengwangca
Copy link
Contributor

Close this PR and continue the review in [Java] Implement the trust store delegate API for customized device attestation #25471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcarmelveilleux tcarmelveilleux tcarmelveilleux left review comments

@yufengwangca yufengwangca yufengwangca left review comments

@Damian-Nordic Damian-Nordic Damian-Nordic approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@CodeChronos928 CodeChronos928 Awaiting requested review from CodeChronos928

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@ksperling-apple ksperling-apple Awaiting requested review from ksperling-apple

@lazarkov lazarkov Awaiting requested review from lazarkov

@lpbeliveau-silabs lpbeliveau-silabs Awaiting requested review from lpbeliveau-silabs

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@msandstedt msandstedt Awaiting requested review from msandstedt

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@turon turon Awaiting requested review from turon

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@jmeg-sfy jmeg-sfy Awaiting requested review from jmeg-sfy

@pjzander-signify pjzander-signify Awaiting requested review from pjzander-signify

@amitnj amitnj Awaiting requested review from amitnj

@nivi-apple nivi-apple Awaiting requested review from nivi-apple

Assignees
No one assigned
Labels
controller examples review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@panliming-tuya @joonhaengHeo @yufengwangca @tcarmelveilleux @Damian-Nordic @restyled-commits