-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Undo renames in idl test inputs. #24269
Merged
andy31415
merged 3 commits into
project-chip:master
from
andy31415:undo_ota_provider_rename_in_test_inputs
Jan 6, 2023
Merged
Undo renames in idl test inputs. #24269
andy31415
merged 3 commits into
project-chip:master
from
andy31415:undo_ota_provider_rename_in_test_inputs
Jan 6, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes in project-chip#24235 updated these files as well, but seemingly incomplete (because struct names were changed but not their usage). Expecting this reverts back the idl test inputs and should have no side effects.
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
January 4, 2023 20:36
pullapprove
bot
requested review from
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 4, 2023 20:36
PR #24269: Size comparison from b921798 to 8a69565 Increases (7 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, cyw30739, nrfconnect, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 4, 2023
PR #24269: Size comparison from fbaa1fe to 7d4f164 Increases (7 builds for bl602, bl702, psoc6, telink)
Decreases (5 builds for esp32, psoc6, qpg)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
* Undo renames in idl test inputs. Changes in project-chip#24235 updated these files as well, but seemingly incomplete (because struct names were changed but not their usage). Expecting this reverts back the idl test inputs and should have no side effects. * Remove wrong indent
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Undo renames in idl test inputs. Changes in project-chip#24235 updated these files as well, but seemingly incomplete (because struct names were changed but not their usage). Expecting this reverts back the idl test inputs and should have no side effects. * Remove wrong indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in #24235 updated these files as well, but seemingly incomplete (because struct names were changed but not their usage).
Expecting this reverts back the idl test inputs and should have no side effects.