-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align naming in OTA clusters better with spec. #24235
Merged
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-ota-bits
Jan 3, 2023
Merged
Align naming in OTA clusters better with spec. #24235
bzbarsky-apple
merged 3 commits into
project-chip:master
from
bzbarsky-apple:rename-ota-bits
Jan 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
app
controller
darwin
documentation
Improvements or additions to documentation
examples
scripts
tests
labels
Jan 3, 2023
Damian-Nordic
approved these changes
Jan 3, 2023
bzbarsky-apple
force-pushed
the
rename-ota-bits
branch
from
January 3, 2023 14:21
2f66c46
to
725620c
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
January 3, 2023 14:22
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
January 3, 2023 14:22
selissia
approved these changes
Jan 3, 2023
PR #24235: Size comparison from 8f9207d to 725620c Increases (6 builds for bl602, cc13x2_26x2, psoc6, telink)
Decreases (13 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Full report (57 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Jan 3, 2023
andy31415
added a commit
to andy31415/connectedhomeip
that referenced
this pull request
Jan 4, 2023
Changes in project-chip#24235 updated these files as well, but seemingly incomplete (because struct names were changed but not their usage). Expecting this reverts back the idl test inputs and should have no side effects.
andy31415
added a commit
that referenced
this pull request
Jan 6, 2023
* Undo renames in idl test inputs. Changes in #24235 updated these files as well, but seemingly incomplete (because struct names were changed but not their usage). Expecting this reverts back the idl test inputs and should have no side effects. * Remove wrong indent
cletnick
pushed a commit
to cletnick/connectedhomeip
that referenced
this pull request
Jan 10, 2023
* Undo renames in idl test inputs. Changes in project-chip#24235 updated these files as well, but seemingly incomplete (because struct names were changed but not their usage). Expecting this reverts back the idl test inputs and should have no side effects. * Remove wrong indent
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
* Undo renames in idl test inputs. Changes in project-chip#24235 updated these files as well, but seemingly incomplete (because struct names were changed but not their usage). Expecting this reverts back the idl test inputs and should have no side effects. * Remove wrong indent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
app
controller
darwin
documentation
Improvements or additions to documentation
examples
review - approved
scripts
tests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REVIEW NOTE: Only the first of the three commits contains manual changes.