-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SetupPayload: Python implementation to generate manual and QRCode #24228
Merged
bzbarsky-apple
merged 7 commits into
project-chip:master
from
shubhamdp:py_onboarding_code
Jan 13, 2023
Merged
SetupPayload: Python implementation to generate manual and QRCode #24228
bzbarsky-apple
merged 7 commits into
project-chip:master
from
shubhamdp:py_onboarding_code
Jan 13, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubhamdp
force-pushed
the
py_onboarding_code
branch
2 times, most recently
from
January 2, 2023 11:31
6cdda64
to
188ac56
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
ksperling-apple,
lazarkov,
lpbeliveau-silabs,
LuDuda,
mlepage-google and
mrjerryjohns
January 2, 2023 11:32
pullapprove
bot
requested review from
tecimovic,
vijs,
vivien-apple,
woody-apple and
xylophone21
January 10, 2023 08:48
jmeg-sfy
approved these changes
Jan 10, 2023
shubhamdp
force-pushed
the
py_onboarding_code
branch
from
January 10, 2023 09:30
52be00c
to
f9767ac
Compare
PR #24228: Size comparison from 5ec8da8 to f9767ac Increases (6 builds for bl702, cc13x2_26x2, esp32, psoc6, telink)
Decreases (6 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
Please check the results in the CI at above place. |
shubhamdp
force-pushed
the
py_onboarding_code
branch
from
January 10, 2023 12:17
f9767ac
to
daa81f6
Compare
PR #24228: Size comparison from cb430db to daa81f6 Increases (8 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (9 builds for bl602, cc13x2_26x2, esp32, nrfconnect, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
shubhamdp
force-pushed
the
py_onboarding_code
branch
from
January 12, 2023 15:00
d72f38c
to
80a510d
Compare
PR #24228: Size comparison from 610c8e5 to 80a510d Increases (8 builds for bl702, cc13x2_26x2, cyw30739, esp32, telink)
Decreases (6 builds for bl602, cc13x2_26x2, k32w, telink)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Added requirements.txt
shubhamdp
force-pushed
the
py_onboarding_code
branch
from
January 13, 2023 03:03
80a510d
to
46053f8
Compare
PR #24228: Size comparison from b36439e to 46053f8 Increases (15 builds for bl702, cc13x2_26x2, esp32, k32w, nrfconnect, psoc6, qpg, telink)
Decreases (5 builds for bl602, cc13x2_26x2, cyw30739, esp32)
Full report (54 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Jan 13, 2023
lecndav
pushed a commit
to lecndav/connectedhomeip
that referenced
this pull request
Mar 22, 2023
…oject-chip#24228) * SetupPayload: Python implementation to generate manual and qrcode Added requirements.txt * Converted to pep8 styling * removed get_short_discriminator method which seemed to be confusing * Unit tests for python setup payload generator * restyled * use the correct script * Not using random dataset but the predefined one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change Overview
Testing
chip-tool
and python script and compare the results.RANDOM
variable