-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
setup_payload: Add support for parsing setup payloads in python impl #32516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shubhamdp
commented
Mar 9, 2024
- Base38 decode impl in python
- use construct to generate/parse setup payload in python
- Add cli to parse and generate using click
- unit tests for parsing and verification using chip-tool
- removed the older script which only generated the codes
- replaced the usage of older utility with newer one
pullapprove
bot
requested review from
andy31415,
andyg-apple,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
cecille,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
Damian-Nordic,
dhrishi,
harsha-rajendran,
hawk248,
hicklin,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
kpschoedel,
ksperling-apple,
lazarkov and
lpbeliveau-silabs
March 9, 2024 11:21
shubhamdp
force-pushed
the
py_onboarding_codes
branch
from
March 9, 2024 15:54
4618708
to
71b501f
Compare
PR #32516: Size comparison from f7a9b59 to f7b8904 Decreases (2 builds for efr32)
Full report (42 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, stm32)
|
shubhamdp
force-pushed
the
py_onboarding_codes
branch
from
March 9, 2024 17:00
f7b8904
to
6256ace
Compare
PR #32516: Size comparison from f7a9b59 to 6256ace Decreases (2 builds for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
- Base38 decode impl in python - use construct to generate/parse setup payload in python - Add cli to parse and generate using click - unit tests for parsing and verification using chip-tool - removed the older script which only generated the codes - replaced the usage of older utility with newer one
shubhamdp
force-pushed
the
py_onboarding_codes
branch
from
March 11, 2024 12:35
6256ace
to
4198a90
Compare
PR #32516: Size comparison from 68c66e3 to 4198a90 Decreases (2 builds for efr32)
Full report (84 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, stm32, telink)
|
PR #32516: Size comparison from c021fad to 139c0b8 Decreases (1 build for efr32)
Full report (94 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, mbed, nrfconnect, nxp, psoc6, qpg, stm32, telink)
|
tcarmelveilleux
approved these changes
May 21, 2024
PR #32516: Size comparison from c021fad to 3ef0728 Increases above 0.2%:
Increases (1 build for stm32)
Decreases (1 build for stm32)
Full report (17 builds for cc13x4_26x4, cc32xx, linux, mbed, nxp, qpg, stm32)
|
@andy31415 Can you please review? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.