-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid usage of a separate build environment for compile time codegen #23861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
lpbeliveau-silabs and
LuDuda
December 1, 2022 18:37
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21 and
yunhanw-google
December 1, 2022 18:37
PR #23861: Size comparison from e0b529e to e954ac9 Increases (6 builds for bl702, cyw30739, psoc6, telink)
Decreases (4 builds for bl602, psoc6, qpg, telink)
Full report (39 builds for bl602, bl702, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Dec 1, 2022
PR #23861: Size comparison from e0b529e to ff284fc Increases (2 builds for bl702)
Decreases (3 builds for nrfconnect, qpg)
Full report (15 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg)
|
PR #23861: Size comparison from e0b529e to 642d79d Increases (9 builds for bl602, bl702, cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (7 builds for cc13x2_26x2, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yufengwangca
approved these changes
Dec 1, 2022
tehampson
approved these changes
Dec 1, 2022
yicheng810
pushed a commit
to yicheng810/connectedhomeip
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
idl
package since that one pulls in a venvAlso fixed a bug where Callback stub jinja template was not considered an input template (so changes to that template would not trigger re-compiles)
This should speed up builds by O(minutes) for clean builds because a separate virtual environment is not created for codegen.