-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OpenThread] Improve OpenThread SED polling logs #23780
Merged
andy31415
merged 1 commit into
project-chip:master
from
jepenven-silabs:improve_ot_logging_sed
Nov 29, 2022
Merged
[OpenThread] Improve OpenThread SED polling logs #23780
andy31415
merged 1 commit into
project-chip:master
from
jepenven-silabs:improve_ot_logging_sed
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c5dd73
to
2be5e0d
Compare
PR #23780: Size comparison from 5ec87ed to 2be5e0d Increases (6 builds for bl702, esp32, k32w, psoc6, telink)
Decreases (8 builds for bl602, esp32, nrfconnect, psoc6, telink)
Full report (42 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jmartinez-silabs
approved these changes
Nov 28, 2022
andy31415
approved these changes
Nov 29, 2022
yicheng810
pushed a commit
to yicheng810/connectedhomeip
that referenced
this pull request
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem :
Current Log assumes that the polling interval will be used if the code returns OT_NO_ERROR.
Actual behaviour is that the OpenThread stack will always use the smallest of the Polling Period and of the MLE_DEFAULT_TIMEOUT.
Update the Logs to show the actual value used by the OpenThread stack.