-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Darwin] MTRDevice should log better #23784
Merged
jtung-apple
merged 3 commits into
project-chip:master
from
jtung-apple:issue-23621-mtrdevice-better-logging
Nov 29, 2022
Merged
[Darwin] MTRDevice should log better #23784
jtung-apple
merged 3 commits into
project-chip:master
from
jtung-apple:issue-23621-mtrdevice-better-logging
Nov 29, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
November 28, 2022 21:21
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
November 28, 2022 21:21
bzbarsky-apple
approved these changes
Nov 28, 2022
PR #23784: Size comparison from e5d6000 to 1be01dc Increases (1 build for bl702)
Decreases (2 builds for bl702, qpg)
Full report (4 builds for bl702, qpg)
|
Co-authored-by: Boris Zbarsky <[email protected]>
Fast-tracking platform-specific fix with platform owner review. |
PR #23784: Size comparison from e5d6000 to f8dbef3 Increases (4 builds for cc13x2_26x2, esp32, psoc6, telink)
Decreases (11 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #23784: Size comparison from e5d6000 to a72ece6 Increases (2 builds for bl602, psoc6)
Decreases (6 builds for esp32, psoc6, qpg, telink)
Full report (53 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23621
This adds some logging, and also fixes a bug when the MTRAsyncCallbackWorkQueue is drained.