Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Darwin] MTRDevice -writeAttributeWithEndpointID completion should reconsider treating values as report #23285

Closed
jtung-apple opened this issue Oct 20, 2022 · 2 comments
Assignees

Comments

@jtung-apple
Copy link
Contributor

Reproduction steps

1. During MTRBaseDevice writeAttributeWithEndpointID completion handler, MTRDevice treats values as report.

Need to evaluate what is appropriate here.

Platform

darwin

Platform Version(s)

1.0

Type

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

Found during code review

Anything else?

Per @bzbarsky-apple 's comment in #23141 about writeAttributeWithEndpointID completion treating values as report - need to reevaluate this and fix as appropriate.

@jtung-apple
Copy link
Contributor Author

I just checked code and I see this was fixed as part of some other previous change in MTRDevice.

@bzbarsky-apple
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants