[Darwin] MTRDevice writes and commands should be serialized along with reads #23141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
jtung-apple
force-pushed
the
issue-23066-darwin-mtrdevice-serialize-writes-commands
branch
from
62425a0 to
0e7da15
Compare
|
PR #23141: Size comparison from a35ee1b to 0e7da15 Increases (7 builds for cyw30739, esp32, k32w, psoc6, qpg, telink)
Decreases (8 builds for bl602, bl702, esp32, k32w, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #23141: Size comparison from a35ee1b to a142560 Increases (6 builds for bl702, k32w, qpg, telink)
Decreases (1 build for k32w)
Full report (15 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
jtung-apple
force-pushed
the
issue-23066-darwin-mtrdevice-serialize-writes-commands
branch
from
a142560 to
da55472
Compare
|
PR #23141: Size comparison from b9d32ec to da55472 Increases (6 builds for cc13x2_26x2, esp32, k32w, psoc6)
Decreases (4 builds for esp32, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #23141: Size comparison from b9d32ec to 4601a1b Increases (7 builds for bl602, bl702, cc13x2_26x2, k32w, linux)
Decreases (7 builds for bl702, cc13x2_26x2, nrfconnect, qpg, telink)
Full report (24 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
…t the range clamping since having NSNumber values exceeding ranges would result in undefined / unexpected values
|
PR #23141: Size comparison from b9d32ec to 3da7b35 Increases (13 builds for bl602, bl702, k32w, linux, psoc6, telink)
Decreases (7 builds for bl702, cyw30739, esp32, nrfconnect, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
PR #23141: Size comparison from b9d32ec to 75a0b17 Increases (5 builds for bl602, psoc6)
Decreases (12 builds for cyw30739, esp32, k32w, nrfconnect, psoc6)
Full report (17 builds for bl602, cyw30739, esp32, k32w, mbed, nrfconnect, psoc6)
|
bzbarsky-apple
approved these changes
Oct 26, 2022
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…h reads (project-chip#23141) * [Darwin] MTRDevice writes and commands should be serialized along with reads * Add _Nullable in implementation to match header for better documentation * Added back MTRDevice -newBaseDevice * Added header doc changes about nullable expected values and expected values interval * Implementation of clamping timeout values according to header intention and spec * Unlinked timed invoke and expected value interval. Unrelated, but kept the range clamping since having NSNumber values exceeding ranges would result in undefined / unexpected values * Address review comments * Clarification on expectedValues and expectedValueInterval * Typo * Update src/darwin/Framework/CHIP/MTRDevice.h Co-authored-by: Boris Zbarsky <[email protected]> * Update src/darwin/Framework/CHIP/MTRDevice.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…h reads (project-chip#23141) * [Darwin] MTRDevice writes and commands should be serialized along with reads * Add _Nullable in implementation to match header for better documentation * Added back MTRDevice -newBaseDevice * Added header doc changes about nullable expected values and expected values interval * Implementation of clamping timeout values according to header intention and spec * Unlinked timed invoke and expected value interval. Unrelated, but kept the range clamping since having NSNumber values exceeding ranges would result in undefined / unexpected values * Address review comments * Clarification on expectedValues and expectedValueInterval * Typo * Update src/darwin/Framework/CHIP/MTRDevice.h Co-authored-by: Boris Zbarsky <[email protected]> * Update src/darwin/Framework/CHIP/MTRDevice.h Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23066
This change makes writes and commands in the MTRDevice set of APIs perform on the same serial queue as read, to avoid the scenario described in #23066 .