Stop using ReadInteraction APIs for Darwin framework read/subscribe. #23534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq and
Byungjoo-Lee
pullapprove
bot
requested review from
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
pullapprove
bot
requested review from
wbschiller,
woody-apple and
xylophone21
|
PR #23534: Size comparison from b278e34 to ee50318 Increases (5 builds for bl602, bl702, cc13x2_26x2, esp32)
Decreases (8 builds for bl602, cc13x2_26x2, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
reduce-Darwin-build-times
branch
from
ee50318 to
78d8afb
Compare
bzbarsky-apple
force-pushed
the
reduce-Darwin-build-times
branch
from
78d8afb to
9b260e1
Compare
|
PR #23534: Size comparison from b0d92ca to 9b260e1 Increases (2 builds for esp32, qpg)
Decreases (5 builds for bl602, bl702, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Nov 8, 2022
woody-apple
previously approved these changes
Nov 8, 2022
bzbarsky-apple
force-pushed
the
reduce-Darwin-build-times
branch
from
9b260e1 to
e649d1a
Compare
bzbarsky-apple
dismissed
woody-apple’s stale review
Significant changes to the code after the review.
|
PR #23534: Size comparison from b87a86b to e649d1a Increases (8 builds for bl602, cc13x2_26x2, psoc6, telink)
Decreases (6 builds for bl702, cc13x2_26x2, cyw30739, esp32, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Nov 16, 2022
|
Fast-tracking platform-specific change with platform owner review. |
This reduces Darwin build CI times from ~2 hours 30 mins to ~1 hour 20 mins and reduces the size of a release unstripped framework from ~430MB to ~300MB. Also fixes support for setting resubscribeIfLost to false in the Darwin "subscribe an attribute" APIs.
bzbarsky-apple
force-pushed
the
reduce-Darwin-build-times
branch
from
e649d1a to
61f38d6
Compare
|
PR #23534: Size comparison from 26e3636 to 61f38d6 Increases (4 builds for bl602, esp32, psoc6, telink)
Decreases (4 builds for bl702, esp32, psoc6, telink)
Full report (51 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…roject-chip#23534) This reduces Darwin build CI times from ~2 hours 30 mins to ~1 hour 20 mins and reduces the size of a release unstripped framework from ~430MB to ~300MB. Also fixes support for setting resubscribeIfLost to false in the Darwin "subscribe an attribute" APIs.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…roject-chip#23534) This reduces Darwin build CI times from ~2 hours 30 mins to ~1 hour 20 mins and reduces the size of a release unstripped framework from ~430MB to ~300MB. Also fixes support for setting resubscribeIfLost to false in the Darwin "subscribe an attribute" APIs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduces Darwin build CI times from ~2 hours 30 mins to ~1 hour 20 mins.
Also includes the following fixes:
attribute" APIs.
"subscribe an attribute" commands. It used to be ignored, because the
underlying API did not support setting it to false.
YAML tests.
this, we could end up with an OnError callback, which would queue a task to
delete the bridge, but then OnDone for a subscription would also delete the
bridge. This would fail any time a subscription in fact errored out. In the
new setup, mKeepAlive only gets set for subscriptions, and only once we have
started the async process that will always call OnDone, so we can rely on
deleting on error if !mKeepAlive and deleting in OnDone if mKeepAlive.
MTRBaseDevice.
@andy31415 @jtung-apple @vivien-apple