-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop using ReadInteraction APIs for Darwin framework read/subscribe.
This reduces Darwin build CI times from ~2 hours 30 mins to ~1 hour 20 mins. Also includes the following fixes: * Fix support for setting resubscribeIfLost to false in the Darwin "subsribe an attribute" APIs. * Fix handling of the --autoResubscribe argument for darwin-framework-tool "subscribe an attribute" commands. It used to be ignored, because the underlying API did not support setting it to false. * Fix handling of fabricFiltered and keepSubscriptions in darwin-framework-tool YAML tests. * Fix handling of the mKeepAlive member of Darwin callback bridges. Before this, we could end up with an OnError callback, which would queue a task to delete the bridge, but then OnDone for a subscription would also delete the bridge. This would fail any time a subscription in fact errored out. In the new setup, mKeepAlive only gets set for subscriptions, and only once we have started the async process that will always call OnDone, so we can rely on deleting on error if !mKeepAlive and deleting in OnDone if mKeepAlive.
- Loading branch information
1 parent
092c91c
commit 78d8afb
Showing
13 changed files
with
29,547 additions
and
47,674 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.