-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove parcelable in android device controller network credential #23327
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/remove_parcel
Oct 27, 2022
Merged
remove parcelable in android device controller network credential #23327
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/remove_parcel
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarcosb
reviewed
Oct 24, 2022
src/controller/java/src/chip/devicecontroller/NetworkCredentials.java
Outdated
Show resolved
Hide resolved
gmarcosb
approved these changes
Oct 24, 2022
yufengwangca
approved these changes
Oct 24, 2022
ed17ae8
to
3278fbc
Compare
PR #23327: Size comparison from 0998742 to 3278fbc Increases (10 builds for bl602, bl702, cyw30739, psoc6, telink)
Decreases (3 builds for efr32, nrfconnect, psoc6)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
reviewed
Oct 24, 2022
3278fbc
to
bfe4d3f
Compare
PR #23327: Size comparison from 0d6c60f to bfe4d3f Increases (4 builds for cc13x2_26x2, esp32, nrfconnect, psoc6)
Decreases (8 builds for bl602, cc13x2_26x2, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
0d812c2
to
b6da341
Compare
gmarcosb
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!
gmarcosb
reviewed
Oct 26, 2022
examples/android/CHIPTool/app/src/main/java/com/google/chip/chiptool/CHIPToolActivity.kt
Outdated
Show resolved
Hide resolved
95c3ea7
to
7417c54
Compare
7417c54
to
66e2a98
Compare
jmartinez-silabs
approved these changes
Oct 26, 2022
PR #23327: Size comparison from 5b7cf96 to 66e2a98 Increases (5 builds for bl602, cc13x2_26x2, esp32, nrfconnect, telink)
Decreases (4 builds for psoc6, qpg)
Full report (47 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#23811
we should have no Parcelable structures in the Controller Java API
if anything on android needs to serialize, then it should create its own Parcelable NetworkCredentials & copy the fields into the Controller API one.
For chip-tool android application, we use dedicated NetworkCredentialParcelable, then copy fields from NetworkCredentialParcelable to NetworkCredential so that Java controller can handle it.
This work is part of #23133 and prerequisite for #23261, where we are decouple android stuffs from java device controller.