-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add android dummy stub for java matter controller application #23261
Merged
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/remove_android
Oct 28, 2022
Merged
add android dummy stub for java matter controller application #23261
yunhanw-google
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/remove_android
Oct 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #23261: Size comparison from e4f60ce to 0511037 Increases (3 builds for cc13x2_26x2, telink)
Decreases (6 builds for bl602, cc13x2_26x2, cyw30739, esp32, psoc6)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/remove_android
branch
from
October 21, 2022 18:02
0511037
to
93b778b
Compare
PR #23261: Size comparison from 559c7d5 to 93b778b Increases (4 builds for bl602, k32w)
Decreases (2 builds for bl702, telink)
Full report (21 builds for bl602, bl702, cc13x2_26x2, k32w, linux, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/remove_android
branch
2 times, most recently
from
October 21, 2022 21:36
597f049
to
c57db7b
Compare
yunhanw-google
changed the title
[Draft]add android dummy stub for java matter controller application
add android dummy stub for java matter controller application
Oct 21, 2022
PR #23261: Size comparison from 559c7d5 to c57db7b Increases (12 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, psoc6, telink)
Decreases (2 builds for cc13x2_26x2, psoc6)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/remove_android
branch
2 times, most recently
from
October 24, 2022 07:03
bbba191
to
2b8951d
Compare
PR #23261: Size comparison from b9d32ec to 2b8951d Increases (7 builds for bl602, esp32, k32w, psoc6, telink)
Decreases (7 builds for bl702, esp32, psoc6, qpg, telink)
Full report (31 builds for bl602, bl702, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/remove_android
branch
2 times, most recently
from
October 24, 2022 16:46
4dcddd3
to
732dcf2
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic and
dhrishi
October 24, 2022 16:50
yunhanw-google
force-pushed
the
feature/remove_android
branch
from
October 27, 2022 05:48
3b99a10
to
c13c7fb
Compare
PR #23261: Size comparison from bd2c96a to c13c7fb Increases (3 builds for k32w, psoc6)
Decreases (6 builds for bl602, bl702, telink)
Full report (44 builds for bl602, bl702, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
g-coppock
approved these changes
Oct 27, 2022
examples/java-matter-controller/java/src/com/matter/controller/Main.java
Outdated
Show resolved
Hide resolved
examples/java-matter-controller/stub_src/android/annotations/Nullable.java
Outdated
Show resolved
Hide resolved
yunhanw-google
force-pushed
the
feature/remove_android
branch
5 times, most recently
from
October 27, 2022 21:41
8128420
to
6fa3713
Compare
PR #23261: Size comparison from d65a207 to 6fa3713 Increases (5 builds for bl602, bl702, esp32, psoc6, qpg)
Decreases (5 builds for efr32, nrfconnect, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/remove_android
branch
3 times, most recently
from
October 28, 2022 01:46
facbcd7
to
dd3ec53
Compare
yunhanw-google
force-pushed
the
feature/remove_android
branch
from
October 28, 2022 01:51
dd3ec53
to
98a07f6
Compare
yufengwangca
approved these changes
Oct 28, 2022
PR #23261: Size comparison from 236e14e to 98a07f6 Increases (7 builds for bl702, cc13x2_26x2, esp32, psoc6)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, esp32, k32w, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
yufengwangca
requested review from
g-coppock
and removed request for
jtung-apple
October 28, 2022 15:20
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems:
#23811
The goal for java controller application is to exercise the java layer's commission and cluster interaction flow against all-cluster-app or other server app in CI, mac and linux machines. Currently java controller application depends on prebuilt android.jar targeted for android phone, which cannot be run directly in mac and linux host, in addition, multiple shared libraries from NDM, like libm.so, cannot run in host directly.
We need resolve this issue with two stages:
Since several android specific APIs have been used in multiple controller java files, for example, logging, bluetooth , we are providing the dummy stub implementation to bypass the actual android library, this way, we still can exercise the key commissioning code flow and cluster interactions. The dummy stub are provided in this PR.
We need to rework Add the initial skeleton of Matter Controller Java CLI App #23048 where it use ndk's compiler, instead, we should use linux/mac chip-tool example as reference and start to the compiler from host directly. After this works, the shared libaries used by controller application should work as espected.