-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop excluding MTRBaseClusters files from restyling. #23056
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-restyle-exclusions
Oct 14, 2022
Merged
Stop excluding MTRBaseClusters files from restyling. #23056
bzbarsky-apple
merged 1 commit into
project-chip:master
from
bzbarsky-apple:remove-restyle-exclusions
Oct 14, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
mspang
October 6, 2022 18:11
pullapprove
bot
requested review from
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
October 6, 2022 18:11
andy31415
approved these changes
Oct 6, 2022
PR #23056: Size comparison from 530adb6 to cbca422 Increases (5 builds for cc13x2_26x2, efr32, esp32, psoc6)
Decreases (5 builds for bl602, bl702, cc13x2_26x2, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Oct 12, 2022
It looks like the restyle job and the zap job agree on them now, as long as we avoid the failure case of an input on which running clang-format once produces different output from running clang-format twice. Fixes project-chip#20236
bzbarsky-apple
force-pushed
the
remove-restyle-exclusions
branch
from
October 13, 2022 17:43
cbca422
to
4e3626c
Compare
PR #23056: Size comparison from 9beda1c to 4e3626c Increases (5 builds for cc13x2_26x2, esp32, telink)
Decreases (12 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the restyle job and the zap job agree on them now, as long as we avoid the failure case of an input on which running clang-format once produces different output from running clang-format twice.
Fixes #20236
The clang-format failure case is tracked in llvm/llvm-project#58202