ZAP and restyled disagree on styling for src/darwin/Framework/CHIP/zap-generated/MTRClustersObjc.mm #20236
Comments
|
@vivien-apple @woody-apple Any idea why this disagreement? |
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Oct 6, 2022
It looks like the restyle job and the zap job agree on them now, as long as we avoid the failure case of an input on which running clang-format once produces different output from running clang-format twice. Fixes project-chip#20236
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this issue
Oct 13, 2022
It looks like the restyle job and the zap job agree on them now, as long as we avoid the failure case of an input on which running clang-format once produces different output from running clang-format twice. Fixes project-chip#20236
bzbarsky-apple
added a commit
that referenced
this issue
Oct 14, 2022
It looks like the restyle job and the zap job agree on them now, as long as we avoid the failure case of an input on which running clang-format once produces different output from running clang-format twice. Fixes #20236
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problem
Ran into this in #20139. Restyled is insisting on putting in a weird linebreak, while the version of clang-format ZAP runs does not. So we can't have a version of the file that passes both the ZAP job and the restyled job.
Proposed Solution
Sort out how to get the two to agree. For now I have whitelisted this file to not be run through restyled.
The text was updated successfully, but these errors were encountered: