Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Darwin] Call ResetSharedConnection and not StartSharedConnection in … #22810

Merged
merged 1 commit into from
Sep 22, 2022
Merged

[Darwin] Call ResetSharedConnection and not StartSharedConnection in … #22810

merged 1 commit into from
Sep 22, 2022

Conversation

vivien-apple
Copy link
Contributor

…src/platform/Darwin/DnssdHostNameRegistrar.cpp in order to properly unregister / register interfaces addresses

Issue Being Resolved

Change overview

  • Use the right method call...

@vivien-apple
[Darwin] Call ResetSharedConnection and not StartSharedConnection in …
6f494b8 
…src/platform/Darwin/DnssdHostNameRegistrar.cpp in order to properly unregister / register interfaces addresses
@vivien-apple vivien-apple self-assigned this Sep 22, 2022
@github-actions
Copy link

github-actions bot commented Sep 22, 2022 •
edited
Loading

PR #22810: Size comparison from 7189344 to 6f494b8

Increases (7 builds for bl602, bl702, psoc6, qpg, telink)
platform target config section 71893448 6f494b8 change % change
bl602 lighting-app bl602 (read/write) 1383302 1383310 8 0.0
.text 1064952 1064954 2 0.0
bl702 lighting-app bl702 .debug_info 37896039 37896040 1 0.0
.text 956818 956820 2 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22399178 22399179 1 0.0
qpg lock-app qpg6105+debug (read/write) 1116212 1116220 8 0.0
.text 563312 563320 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 814460 814468 8 0.0
text 574564 574568 4 0.0
lighting-app tlsr9518adk80d text 592784 592788 4 0.0
ota-requestor-app tlsr9518adk80d (read/write) 844524 844532 8 0.0
text 598968 598970 2 0.0
Decreases (3 builds for bl602, esp32, psoc6)
platform target config section 71893448 6f494b8 change % change
bl602 lighting-app bl602+rpc .text 1096300 1096298 -2 -0.0
esp32 all-clusters-app c3devkit (read only) 1222930 1222926 -4 -0.0
.flash.text 1222930 1222926 -4 -0.0
psoc6 all-clusters-minimal cy8ckit_062s2_43012 .debug_info 26555632 26555631 -1 -0.0
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section 71893448 6f494b8 change % change
bl602 lighting-app bl602 (read/write) 1383302 1383310 8 0.0
.bss 89537 89537 0 0.0
.data 9816 9816 0 0.0
.text 1064952 1064954 2 0.0
bl602+rpc (read/write) 1428506 1428506 0 0.0
.bss 96969 96969 0 0.0
.data 10200 10200 0 0.0
.text 1096300 1096298 -2 -0.0
bl702 lighting-app bl702 (read only) 3262 3262 0 0.0
(read/write) 1188179 1188179 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 67078 67078 0 0.0
.bss_psram 29696 29696 0 0.0
.comment 48 48 0 0.0
.data 4280 4280 0 0.0
.debug_abbrev 1506715 1506715 0 0.0
.debug_aranges 133088 133088 0 0.0
.debug_frame 486412 486412 0 0.0
.debug_info 37896039 37896040 1 0.0
.debug_line 5252141 5252141 0 0.0
.debug_loc 3362527 3362527 0 0.0
.debug_ranges 359760 359760 0 0.0
.debug_str 3455801 3455801 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 116488 116488 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 564895 564895 0 0.0
.symtab 171616 171616 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
956818 956820 2 0.0
bl702+rpc (read only) 3262 3262 0 0.0
(read/write) 1284107 1284107 0 0.0
.bleromro 6296 6296 0 0.0
.bleromrw 124 124 0 0.0
.boot2 688 688 0 0.0
.bss 75126 75126 0 0.0
.bss_psram 29936 29936 0 0.0
.comment 48 48 0 0.0
.data 4800 4800 0 0.0
.debug_abbrev 1644294 1644294 0 0.0
.debug_aranges 140592 140592 0 0.0
.debug_frame 511788 511788 0 0.0
.debug_info 41802659 41802659 0 0.0
.debug_line 5626680 5626680 0 0.0
.debug_loc 3555234 3555234 0 0.0
.debug_ranges 382216 382216 0 0.0
.debug_str 3851768 3851768 0 0.0
.hbn 509 509 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 129896 129896 0 0.0
.rsvd 3188 3188 0 0.0
.shstrtab 293 293 0 0.0
.stack 2048 2048 0 0.0
.strtab 624068 624068 0 0.0
.symtab 189424 189424 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3262 3262 0 0.0
.text 0 0 0 0.0
1030522 1030522 0 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 676595 676595 0 0.0
(read/write) 174940 174940 0 0.0
.bss 81228 81228 0 0.0
.data 3380 3380 0 0.0
.rodata 89603 89603 0 0.0
.text 586680 586680 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 640843 640843 0 0.0
(read/write) 157996 157996 0 0.0
.bss 80500 80500 0 0.0
.data 3380 3380 0 0.0
.rodata 78739 78739 0 0.0
.text 561784 561784 0 0.0
lock-ftd LP_CC2652R7 (read only) 678127 678127 0 0.0
(read/write) 170576 170576 0 0.0
.bss 78484 78484 0 0.0
.data 3304 3304 0 0.0
.rodata 77287 77287 0 0.0
.text 600360 600360 0 0.0
lock-mtd LP_CC2652R7 (read only) 661947 661947 0 0.0
(read/write) 182444 182444 0 0.0
.bss 74172 74172 0 0.0
.data 3304 3304 0 0.0
.rodata 103123 103123 0 0.0
.text 558344 558344 0 0.0
pump-app LP_CC2652R7 (read only) 687283 687283 0 0.0
(read/write) 162124 162124 0 0.0
.bss 78420 78420 0 0.0
.data 3296 3296 0 0.0
.rodata 90507 90507 0 0.0
.text 596292 596292 0 0.0
pump-controller-app LP_CC2652R7 (read only) 671791 671791 0 0.0
(read/write) 177728 177728 0 0.0
.bss 78532 78532 0 0.0
.data 3292 3292 0 0.0
.rodata 86063 86063 0 0.0
.text 585248 585248 0 0.0
shell LP_CC2652R7 (read only) 667622 667622 0 0.0
(read/write) 186224 186224 0 0.0
.bss 83540 83540 0 0.0
.data 3376 3376 0 0.0
.rodata 86318 86318 0 0.0
.text 580988 580988 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 587330 587330 0 0.0
.app_xip_area 463988 463988 0 0.0
.bss 65776 65776 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 594394 594394 0 0.0
.app_xip_area 465724 465724 0 0.0
.bss 71096 71096 0 0.0
.data 752 752 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 543330 543330 0 0.0
.app_xip_area 425012 425012 0 0.0
.bss 60784 60784 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1110520 1110520 0 0.0
.bss 136532 136532 0 0.0
.data 2072 2072 0 0.0
.text 971896 971896 0 0.0
BRD4161A+rpc (read/write) 973644 973644 0 0.0
.bss 151044 151044 0 0.0
.data 2252 2252 0 0.0
.text 820328 820328 0 0.0
BRD4161A+rs911x (read/write) 1003768 1003768 0 0.0
.bss 169368 169368 0 0.0
.data 2064 2064 0 0.0
.text 832316 832316 0 0.0
lock-app BRD4161A+wf200 (read/write) 1151308 1151308 0 0.0
.bss 152248 152248 0 0.0
.data 2072 2072 0 0.0
.text 996968 996968 0 0.0
window-app BRD4161A (read/write) 1102568 1102568 0 0.0
.bss 137980 137980 0 0.0
.data 2096 2096 0 0.0
.text 962472 962472 0 0.0
esp32 all-clusters-app c3devkit (read only) 1222930 1222926 -4 -0.0
(read/write) 1788046 1788046 0 0.0
.dram0.bss 76944 76944 0 0.0
.dram0.data 13840 13840 0 0.0
.flash.rodata 257616 257616 0 0.0
.flash.text 1222930 1222926 -4 -0.0
.iram0.text 65204 65204 0 0.0
m5stack (read only) 1232991 1232991 0 0.0
(read/write) 563948 563948 0 0.0
.dram0.bss 82304 82304 0 0.0
.dram0.data 34296 34296 0 0.0
.flash.rodata 314680 314680 0 0.0
.flash.text 1227607 1227607 0 0.0
.iram0.text 123939 123939 0 0.0
k32w light k32w0+release (read/write) 649900 649900 0 0.0
.bss 70712 70712 0 0.0
.data 2068 2068 0 0.0
.text 574392 574392 0 0.0
lock k32w0+release (read/write) 706856 706856 0 0.0
.bss 71160 71160 0 0.0
.data 2076 2076 0 0.0
.text 630892 630892 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10361076 10361076 0 0.0
(read/write) 706273 706273 0 0.0
.bss 33953 33953 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 650560 650560 0 0.0
.dynamic 560 560 0 0.0
.got 13912 13912 0 0.0
.init 24 24 0 0.0
.init_array 208 208 0 0.0
.rodata 505940 505940 0 0.0
.text 8201140 8201140 0 0.0
thermostat-no-ble arm64 (read only) 2387420 2387420 0 0.0
(read/write) 143649 143649 0 0.0
.bss 55361 55361 0 0.0
.data 1912 1912 0 0.0
.data.rel.ro 77208 77208 0 0.0
.dynamic 560 560 0 0.0
.got 5192 5192 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 143636 143636 0 0.0
.text 2001472 2001472 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2455640 2455640 0 0.0
.bss 215044 215044 0 0.0
.data 5872 5872 0 0.0
.text 1418284 1418284 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1182835 1182835 0 0.0
bss 144433 144433 0 0.0
rodata 144196 144196 0 0.0
text 815292 815292 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1161487 1161487 0 0.0
bss 143660 143660 0 0.0
rodata 135768 135768 0 0.0
text 803160 803160 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 0 0 0 0.0
(read only) 841968 841968 0 0.0
(read/write) 1744300 1744300 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 188712 188712 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1229274 1229274 0 0.0
.debug_aranges 111824 111824 0 0.0
.debug_frame 373360 373360 0 0.0
.debug_info 26818848 26818848 0 0.0
.debug_line 3668702 3668702 0 0.0
.debug_loc 3581471 3581471 0 0.0
.debug_ranges 340096 340096 0 0.0
.debug_str 3439576 3439576 0 0.0
.heap 841968 841968 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 569547 569547 0 0.0
.symtab 421040 421040 0 0.0
.text 1544536 1544536 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 0 0 0 0.0
(read only) 842704 842704 0 0.0
(read/write) 1686916 1686916 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 187976 187976 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2664 2664 0 0.0
.debug_abbrev 1221073 1221073 0 0.0
.debug_aranges 111296 111296 0 0.0
.debug_frame 376440 376440 0 0.0
.debug_info 26555632 26555631 -1 -0.0
.debug_line 3689418 3689418 0 0.0
.debug_loc 3569108 3569108 0 0.0
.debug_ranges 338712 338712 0 0.0
.debug_str 3428589 3428589 0 0.0
.heap 842704 842704 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 533636 533636 0 0.0
.symtab 407472 407472 0 0.0
.text 1487888 1487888 0 0.0
.zero.table 8 8 0 0.0
light cy8ckit_062s2_43012 0 0 0 0.0
(read only) 850896 850896 0 0.0
(read/write) 1605460 1605460 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 179992 179992 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1055129 1055129 0 0.0
.debug_aranges 103504 103504 0 0.0
.debug_frame 346768 346768 0 0.0
.debug_info 22019810 22019810 0 0.0
.debug_line 3259338 3259338 0 0.0
.debug_loc 3267187 3267187 0 0.0
.debug_ranges 304040 304040 0 0.0
.debug_str 3234121 3234121 0 0.0
.heap 850896 850896 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 470013 470013 0 0.0
.symtab 375920 375920 0 0.0
.text 1414624 1414624 0 0.0
.zero.table 8 8 0 0.0
lock cy8ckit_062s2_43012 0 0 0 0.0
(read only) 845864 845864 0 0.0
(read/write) 1643324 1643324 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185008 185008 0 0.0
.comment 204 204 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2472 2472 0 0.0
.debug_abbrev 1062548 1062548 0 0.0
.debug_aranges 104176 104176 0 0.0
.debug_frame 349592 349592 0 0.0
.debug_info 22399178 22399179 1 0.0
.debug_line 3268052 3268052 0 0.0
.debug_loc 3307015 3307015 0 0.0
.debug_ranges 307384 307384 0 0.0
.debug_str 3261576 3261576 0 0.0
.heap 845864 845864 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 288 288 0 0.0
.stab 156 156 0 0.0
.stabstr 335 335 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 476253 476253 0 0.0
.symtab 379152 379152 0 0.0
.text 1447456 1447456 0 0.0
.zero.table 8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1146320 1146320 0 0.0
.bss 110544 110544 0 0.0
.data 1028 1028 0 0.0
.text 593416 593416 0 0.0
lock-app qpg6105+debug (read/write) 1116212 1116220 8 0.0
.bss 106376 106376 0 0.0
.data 1032 1032 0 0.0
.text 563312 563320 8 0.0
telink light-switch-app tlsr9518adk80d (read/write) 814460 814468 8 0.0
bss 72172 72172 0 0.0
noinit 43488 43488 0 0.0
text 574564 574568 4 0.0
lighting-app tlsr9518adk80d (read/write) 836572 836572 0 0.0
bss 73028 73028 0 0.0
noinit 43488 43488 0 0.0
text 592784 592788 4 0.0
ota-requestor-app tlsr9518adk80d (read/write) 844524 844532 8 0.0
bss 73936 73936 0 0.0
noinit 43488 43488 0 0.0
text 598968 598970 2 0.0

@bzbarsky-apple
Copy link
Contributor

Fast-tracking platform-specific change with platform owner review.

@bzbarsky-apple bzbarsky-apple merged commit edb93a0 into project-chip:master Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@emargolis emargolis Awaiting requested review from emargolis

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees

@vivien-apple vivien-apple

Labels
fast track review - pending
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Darwin: DNS service connection reset on interface changes
2 participants
@vivien-apple @bzbarsky-apple