Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Darwin: DNS service connection reset on interface changes #22689

Closed
dtodor opened this issue Sep 16, 2022 · 1 comment · Fixed by #22810
Closed

Darwin: DNS service connection reset on interface changes #22689

dtodor opened this issue Sep 16, 2022 · 1 comment · Fixed by #22810

Comments

@dtodor
Copy link

dtodor commented Sep 16, 2022

Shouldn't this read ResetSharedConnection instead of StartSharedConnection:

ReturnOnFailure(StartSharedConnection());

The callback will be invoked on interface changes and will fail since the connection already exists.

@vivien-apple
Copy link
Contributor

As you may have guessed I have written the code for this method but apparently I did a typo while cleaning up my changes. Thanks for catching it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants