Update TestEventTrigger to match SVE2 test plan #22695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- There was a 3-way mismatch between spec, SDK and SVE2 test plans in the TestEventTrigger command. - Since this command is meant for cert testing and 1.0 spec is loced down, it was determined that making behavior match TC-DGEN-2.3 is the best outcome. Fixes project-chip#22232 Changes: - Make all EnableKey errors are ConstraintError - Add test event trigger support to all Linux examples by default with a command that always succeeds in the reserved range - Add integration test for feature - Fix Python IM status codes list that had an old name - Add "commission-only" mode to matter_testing_support.py done while testing this feature Testing done: - All unit tests still pass - Integration tests pass, including new TC_TestEventTrigger.py
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mlepage-google,
msandstedt,
rgoliver and
robszewczyk
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
andy31415
approved these changes
Sep 16, 2022
|
PR #22695: Size comparison from 69551a1 to 8231799 Increases (1 build for bl702)
Decreases (2 builds for bl702)
Full report (2 builds for bl702)
|
|
PR #22695: Size comparison from 69551a1 to 0f2c368 Increases above 0.2%:
Increases (18 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6)
Decreases (26 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, mbed, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
msandstedt
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Fixes [SVE2 feedback] TestEventTrigger uses non-spec-compliant status code #22232
There was a 3-way mismatch between spec, SDK and SVE2 test plans in the TestEventTrigger command.
Since this command is meant for cert testing and 1.0 spec is loced down, it was determined that making behavior match TC-DGEN-2.3 is the best outcome.
Change overview
Testing done: