[SVE2 feedback] TestEventTrigger uses non-spec-compliant status code

[tcarmelveilleux]

Problem

Found during SVE2

In General Commissioning Cluster TestEventTrigger command, when EnableKey is given incorrectly, the spec says EnableKeyMismatch status code should be given.

Spec:

11.11.8.1. TestEventTrigger Command

In order to prevent unwittingly actuating a particular trigger, this command SHALL respond with the cluster-specific error status code EnableKeyMismatch if the EnableKey field does not match the a-priori value configured on the device

However, the SDK currently uses UNSUPPORTED_ACCESS:

if (triggerDelegate == nullptr || !triggerDelegate->DoesEnableKeyMatch(commandData.enableKey))
{
    commandObj->AddStatus(commandPath, Status::UnsupportedAccess);
    return true;
}

Also, the SDK never got the EnableKeyMismatch enum, and this would probably break wire compatibility.

Proposed Solution

Either:

• Update spec and SDK to use INVALID_COMMAND instead (which would be logical and match test plan), and would likely be less problematic for controllers in terms of wire format
• Add the correct cluster-specific status

[tcarmelveilleux]

After discussions with @robszewczyk regarding the state of the spec, we will make the SDK match the test plans, and will amend the spec post-1.0. Since the only differences are in error paths, and error paths can always be detected differently than success paths, and nobody actually used TestEvenTrigger in test plasn in 1.0, we can fix it like that.

[tcarmelveilleux]

This impacts TC-DGEN-2.3