-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all mention of "pairing" from Darwin public APIs. #22676
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:darwin-no-pairing-in-api
Sep 15, 2022
Merged
Remove all mention of "pairing" from Darwin public APIs. #22676
bzbarsky-apple
merged 2 commits into
project-chip:master
from
bzbarsky-apple:darwin-no-pairing-in-api
Sep 15, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes project-chip#22674 Addresses part of project-chip#22420
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs and
jtung-apple
September 15, 2022 17:04
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
September 15, 2022 17:04
vivien-apple
approved these changes
Sep 15, 2022
PR #22676: Size comparison from 7d707fa to 78d6f9a Increases (5 builds for cc13x2_26x2, cyw30739, psoc6, telink)
Decreases (9 builds for bl602, bl702, cc13x2_26x2, psoc6, qpg, telink)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Fast-tracking platform-specific change with platform owner review |
andy31415
approved these changes
Sep 15, 2022
woody-apple
approved these changes
Sep 15, 2022
jtung-apple
approved these changes
Sep 15, 2022
PR #22676: Size comparison from 8e1c833 to 6438ab1 Increases (3 builds for cc13x2_26x2, psoc6)
Decreases (10 builds for bl602, cc13x2_26x2, esp32, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
jtung-apple
approved these changes
Sep 15, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 16, 2022
This is a re-landing of PR project-chip#22676, but with backwards-compat shims in place. The change to MTRDeviceControllerDelegate is OK because this is a newly-introduced protocol.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…s. (project-chip#23647) This is a re-landing of PR project-chip#22676, but with backwards-compat shims in place. The change to MTRDeviceControllerDelegate is OK because this is a newly-introduced protocol.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
…s. (project-chip#23647) This is a re-landing of PR project-chip#22676, but with backwards-compat shims in place. The change to MTRDeviceControllerDelegate is OK because this is a newly-introduced protocol.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #22420
Issue Being Resolved
Change overview
Rename things and fix comments so there is no mention of "pairing".