Idl lint in ci #22635
Merged
Idl lint in ci #22635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Accepted for 1.0: examples and tooling change only (just more CI validation) |
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost and
kpschoedel
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
… submodules and bootstrap to work
|
PR #22635: Size comparison from e0a9cca to 5eef076 Increases (4 builds for bl702, cc13x2_26x2, nrfconnect, telink)
Decreases (1 build for cc13x2_26x2)
Full report (23 builds for bl602, bl702, cc13x2_26x2, k32w, linux, mbed, nrfconnect, qpg, telink)
|
|
PR #22635: Size comparison from e0a9cca to 69f4eb1 Increases above 0.2%:
Increases (19 builds for bl602, bl702, cc13x2_26x2, efr32, linux, nrfconnect, qpg, telink)
Decreases (10 builds for bl702, cc13x2_26x2, esp32, mbed, qpg)
Full report (30 builds for bl602, bl702, cc13x2_26x2, efr32, esp32, k32w, linux, mbed, nrfconnect, qpg, telink)
|
|
PR #22635: Size comparison from e0a9cca to 7614964 Increases above 0.2%:
Increases (21 builds for bl602, bl702, cc13x2_26x2, cyw30739, linux, nrfconnect, psoc6, qpg, telink)
Decreases (12 builds for bl702, cc13x2_26x2, mbed, psoc6, telink)
Full report (30 builds for bl602, bl702, cc13x2_26x2, cyw30739, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
Files that currently pass the linter: and any new matter files will be required to pass. |
|
PR #22635: Size comparison from 377ac09 to a9484ab Increases (5 builds for bl602, bl702, cc13x2_26x2, psoc6)
Decreases (7 builds for cc13x2_26x2, nrfconnect, psoc6, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
mrjerryjohns
approved these changes
Sep 15, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Add lint step for IDLs in workflows, ensure lint can be run with act * Remove default value for an external array in chef zap files * Ran zap regen for chef stuff * Bootstrap and checkout so that idl script can run, added issues on todo * Set container for lints: we need some packages installed for checkout submodules and bootstrap to work * Fix comment on how to act-execute the lints * Add space before ] for propper scripting * Replace == with = in script * Add more exceptions for the idl linter. virtually all chef files are broken * Use python3 instead of python for check_includes.py Co-authored-by: Andrei Litvin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Closes #22634
Change overview
Run
scripts/idl_lint.pyover all matter files in the repo to not allow it to regress.We have a list of known wrong examples that are skipped and marked the corresponding TODO and issue numbers for them to get fixed.
Fixes a 'default array value' that was present in all chef examples (defaults do not work for external values and all arrays are external)