Address API review issues in MTRControllerFactory. #22606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
pullapprove
bot
added
review - pending
darwin
examples
and removed
examples
darwin
labels
|
PR #22606: Size comparison from 8626d39 to a775d06 Increases (5 builds for bl602, nrfconnect, telink)
Full report (16 builds for bl602, bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-controller-factory
branch
from
a775d06 to
f4058e2
Compare
|
PR #22606: Size comparison from 8626d39 to f4058e2 Increases (7 builds for bl602, bl702, esp32, nrfconnect, telink)
Decreases (4 builds for psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
force-pushed
the
darwin-controller-factory
branch
2 times, most recently
from
17294b2 to
15af58b
Compare
|
PR #22606: Size comparison from 8626d39 to 15af58b Increases (8 builds for bl602, bl702, cc13x2_26x2, psoc6, telink)
Decreases (2 builds for cc13x2_26x2, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
vivien-apple
approved these changes
Sep 14, 2022
* Rename to MTRDeviceControllerFactory. * Change the startup params startServer to shouldStartServer. * Change the startup params init signatures to be more aligned. * Change isRunning to running. * Rename startup to startControllerFactory and add NSError outparam. * Rename shutdown to stopControllerFactory * Rename startControllerOnExistingFabric to createControllerOnExistingFabric and add NSError outparam. * Rename startControllerOnNewFabric to createControllerOnNewFabric and add NSError outparam. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. Fixes project-chip#22594 Addresses part of project-chip#22420
bzbarsky-apple
force-pushed
the
darwin-controller-factory
branch
from
15af58b to
13f34ce
Compare
|
Fast-tracking platform-specific change with platform owner review. |
andy31415
approved these changes
Sep 14, 2022
|
PR #22606: Size comparison from 8c4675f to 13f34ce Increases (7 builds for bl702, cc13x2_26x2, psoc6, qpg, telink)
Decreases (1 build for cc13x2_26x2)
Full report (48 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Rename to MTRDeviceControllerFactory. * Change the startup params startServer to shouldStartServer. * Change the startup params init signatures to be more aligned. * Change isRunning to running. * Rename startup to startControllerFactory and add NSError outparam. * Rename shutdown to stopControllerFactory * Rename startControllerOnExistingFabric to createControllerOnExistingFabric and add NSError outparam. * Rename startControllerOnNewFabric to createControllerOnNewFabric and add NSError outparam. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. Fixes project-chip#22594 Addresses part of project-chip#22420
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 4, 2022
This is a re-landing of PR project-chip#22606 but modified to preserve the old APIs. * Rename to MTRDeviceControllerFactory. * Change the startup params startServer to shouldStartServer. * Change the startup params init signatures to be more aligned. * Change isRunning to running. * Rename startup to startControllerFactory and add NSError outparam. * Rename shutdown to stopControllerFactory * Rename startControllerOnExistingFabric to createControllerOnExistingFabric and add NSError outparam. * Rename startControllerOnNewFabric to createControllerOnNewFabric and add NSError outparam. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * The change in MTRBaseDevice_Internal.h is comment-only. * The change in MTRDeviceController.h should be source and binary compatible. * MTRDeviceControllerFactory_Internal.h is not a public header. * In MTRDeviceControllerStartupParams.h the changes with no shims are either comments or changes to MTR_NEWLY_AVAILABLE APIs. * MTRDeviceControllerStartupParams_Internal.h is not a public header. * MTRDeviceController_Internal.h is not a public header.
bzbarsky-apple
added a commit
to bzbarsky-apple/connectedhomeip
that referenced
this pull request
Nov 4, 2022
This is a re-landing of PR project-chip#22606 but modified to preserve the old APIs. * Rename to MTRDeviceControllerFactory. * Change the startup params startServer to shouldStartServer. * Change the startup params init signatures to be more aligned. * Change isRunning to running. * Rename startup to startControllerFactory and add NSError outparam. * Rename shutdown to stopControllerFactory * Rename startControllerOnExistingFabric to createControllerOnExistingFabric and add NSError outparam. * Rename startControllerOnNewFabric to createControllerOnNewFabric and add NSError outparam. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * The change in MTRBaseDevice_Internal.h is comment-only. * The change in MTRDeviceController.h should be source and binary compatible. * MTRDeviceControllerFactory_Internal.h is not a public header. * In MTRDeviceControllerStartupParams.h the changes with no shims are either comments or changes to MTR_NEWLY_AVAILABLE APIs. * MTRDeviceControllerStartupParams_Internal.h is not a public header. * MTRDeviceController_Internal.h is not a public header.
bzbarsky-apple
added a commit
that referenced
this pull request
Nov 7, 2022
This is a re-landing of PR #22606 but modified to preserve the old APIs. * Rename to MTRDeviceControllerFactory. * Change the startup params startServer to shouldStartServer. * Change the startup params init signatures to be more aligned. * Change isRunning to running. * Rename startup to startControllerFactory and add NSError outparam. * Rename shutdown to stopControllerFactory * Rename startControllerOnExistingFabric to createControllerOnExistingFabric and add NSError outparam. * Rename startControllerOnNewFabric to createControllerOnNewFabric and add NSError outparam. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * The change in MTRBaseDevice_Internal.h is comment-only. * The change in MTRDeviceController.h should be source and binary compatible. * MTRDeviceControllerFactory_Internal.h is not a public header. * In MTRDeviceControllerStartupParams.h the changes with no shims are either comments or changes to MTR_NEWLY_AVAILABLE APIs. * MTRDeviceControllerStartupParams_Internal.h is not a public header. * MTRDeviceController_Internal.h is not a public header.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22606 but modified to preserve the old APIs. * Rename to MTRDeviceControllerFactory. * Change the startup params startServer to shouldStartServer. * Change the startup params init signatures to be more aligned. * Change isRunning to running. * Rename startup to startControllerFactory and add NSError outparam. * Rename shutdown to stopControllerFactory * Rename startControllerOnExistingFabric to createControllerOnExistingFabric and add NSError outparam. * Rename startControllerOnNewFabric to createControllerOnNewFabric and add NSError outparam. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * The change in MTRBaseDevice_Internal.h is comment-only. * The change in MTRDeviceController.h should be source and binary compatible. * MTRDeviceControllerFactory_Internal.h is not a public header. * In MTRDeviceControllerStartupParams.h the changes with no shims are either comments or changes to MTR_NEWLY_AVAILABLE APIs. * MTRDeviceControllerStartupParams_Internal.h is not a public header. * MTRDeviceController_Internal.h is not a public header.
adbridge
pushed a commit
to ARM-software/connectedhomeip
that referenced
this pull request
Nov 18, 2022
This is a re-landing of PR project-chip#22606 but modified to preserve the old APIs. * Rename to MTRDeviceControllerFactory. * Change the startup params startServer to shouldStartServer. * Change the startup params init signatures to be more aligned. * Change isRunning to running. * Rename startup to startControllerFactory and add NSError outparam. * Rename shutdown to stopControllerFactory * Rename startControllerOnExistingFabric to createControllerOnExistingFabric and add NSError outparam. * Rename startControllerOnNewFabric to createControllerOnNewFabric and add NSError outparam. * Fix a leak when we failed to start a controller because it wanted a fabric that does not exist, or wanted a new fabric and a matching one existed. This used to not show up in LSan before, maybe because we did not have an autoreleasepool in place. The header changes not accompanied by backwards-compat shims are OK for the following reasons: * The change in MTRBaseDevice_Internal.h is comment-only. * The change in MTRDeviceController.h should be source and binary compatible. * MTRDeviceControllerFactory_Internal.h is not a public header. * In MTRDeviceControllerStartupParams.h the changes with no shims are either comments or changes to MTR_NEWLY_AVAILABLE APIs. * MTRDeviceControllerStartupParams_Internal.h is not a public header. * MTRDeviceController_Internal.h is not a public header.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses part of #22420
Issue Being Resolved
Change overview
See above.