-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Android/JAVA]add IM isFabricFiltered and keepSubscriptions flag for read/subscribe API #22575
Merged
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/android_im_fabric_filter
Sep 16, 2022
Merged
[Android/JAVA]add IM isFabricFiltered and keepSubscriptions flag for read/subscribe API #22575
andy31415
merged 1 commit into
project-chip:master
from
yunhanw-google:feature/android_im_fabric_filter
Sep 16, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yunhanw-google
force-pushed
the
feature/android_im_fabric_filter
branch
from
September 13, 2022 05:54
110601f
to
01ef9b8
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google and
msandstedt
September 13, 2022 05:55
pullapprove
bot
requested review from
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
September 13, 2022 05:55
PR #22575: Size comparison from 5caec5a to 01ef9b8 Increases (9 builds for bl602, bl702, cc13x2_26x2, esp32, psoc6, qpg, telink)
Decreases (7 builds for cc13x2_26x2, esp32, nrfconnect, psoc6, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Accepted for 1.0: platform-specific (android/java) |
andy31415
approved these changes
Sep 13, 2022
src/controller/java/src/chip/devicecontroller/ChipDeviceController.java
Outdated
Show resolved
Hide resolved
src/controller/java/src/chip/devicecontroller/ChipDeviceController.java
Outdated
Show resolved
Hide resolved
yunhanw-google
force-pushed
the
feature/android_im_fabric_filter
branch
2 times, most recently
from
September 14, 2022 06:09
fd0a192
to
be93862
Compare
PR #22575: Size comparison from 8626d39 to be93862 Increases (10 builds for bl602, bl702, cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (3 builds for cc13x2_26x2, esp32, psoc6)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
yunhanw-google
force-pushed
the
feature/android_im_fabric_filter
branch
2 times, most recently
from
September 14, 2022 17:43
a69318e
to
6789f28
Compare
PR #22575: Size comparison from e0a9cca to 6789f28 Increases (5 builds for cc13x2_26x2, nrfconnect, psoc6, telink)
Decreases (8 builds for bl602, bl702, cc13x2_26x2, esp32, qpg, telink)
Full report (37 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
joonhaengHeo
approved these changes
Sep 15, 2022
yunhanw-google
force-pushed
the
feature/android_im_fabric_filter
branch
from
September 15, 2022 20:12
6789f28
to
bcfdb3f
Compare
yunhanw-google
force-pushed
the
feature/android_im_fabric_filter
branch
from
September 15, 2022 20:16
bcfdb3f
to
c723f91
Compare
PR #22575: Size comparison from bae0bc7 to c723f91 Decreases (2 builds for bl702, telink)
Full report (14 builds for bl702, k32w, linux, mbed, nrfconnect, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Being Resolved
Change overview
Add IM isFabricFiltered and keepSubscriptions flag for read/subscribe API, fix across jni, java, kotlin, android chip-tool.
Disable auto-resubscribe since controller jni is using std::vector, we cannot move the memory to readclient.