Fix ESP32 platform manager shutdown. #22417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The QEMU ESP32 tests start and stop the platform manager several times, and the lack of a shutdown implementation was putting things in a bad state. Also adjusts the test runner script to trigger a test failure when we do end up in that bad state: we were passing even though we crashed quite early in the test run and most of the tests did not run.
bzbarsky-apple
force-pushed
the
fix-esp32-platform-manager-shutdown
branch
from
e3ffa13 to
86dc30f
Compare
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda and
mlepage-google
pullapprove
bot
requested review from
xylophone21,
yufengwangca and
yunhanw-google
|
PR #22417: Size comparison from e535710 to 86dc30f Increases (10 builds for bl602, cc13x2_26x2, esp32, nrfconnect, psoc6, qpg)
Decreases (7 builds for cc13x2_26x2, esp32, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
src/include/platform/internal/GenericPlatformManagerImpl_FreeRTOS.ipp
Outdated
Show resolved
Hide resolved
src/include/platform/internal/GenericPlatformManagerImpl_FreeRTOS.ipp
Outdated
Show resolved
Hide resolved
jmartinez-silabs
approved these changes
Sep 7, 2022
dhrishi
reviewed
Sep 7, 2022
src/include/platform/internal/GenericPlatformManagerImpl_FreeRTOS.ipp
Outdated
Show resolved
Hide resolved
|
Accepted for v1: high value fix for testing only (assuming other FreeRTOS platforms generally have no need to call shutdown, they would just reboot) |
jmartinez-silabs
approved these changes
Sep 7, 2022
|
With the no-deleting change, @jmartinez-silabs @tcarmelveilleux any ideas what might be going on there? |
|
OK, so I now understand why things started failing. There were two problems:
|
jmartinez-silabs
approved these changes
Sep 8, 2022
Ensure we always start with an empty event queue after FreeRTOS _InitChipStack.
bzbarsky-apple
force-pushed
the
fix-esp32-platform-manager-shutdown
branch
from
f6ffaa4 to
cf2d6b8
Compare
|
PR #22417: Size comparison from 0e3bbae to cf2d6b8 Increases above 0.2%:
Increases (33 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, mbed, nrfconnect, psoc6, qpg, telink)
Decreases (8 builds for cc13x2_26x2, telink)
Full report (46 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 8, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Fix ESP32 platform manager shutdown. The QEMU ESP32 tests start and stop the platform manager several times, and the lack of a shutdown implementation was putting things in a bad state. Also adjusts the test runner script to trigger a test failure when we do end up in that bad state: we were passing even though we crashed quite early in the test run and most of the tests did not run. * Address review comments. * Fix unlocking in FreeRTOS _RunEventLoop. Ensure we always start with an empty event queue after FreeRTOS _InitChipStack.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The QEMU ESP32 tests start and stop the platform manager several times, and the
lack of a shutdown implementation was putting things in a bad state.
Also adjusts the test runner script to trigger a test failure when we do end up
in that bad state: we were passing even though we crashed quite early in the
test run and most of the tests did not run.
Fixes #22492
Problem
QEMU tests happily pass when they actually totally fail to run.
Change overview
See above.
Testing
Ran the QEMU tests locally, looked at the logs and the resulting status.