Enable -Wconversion in the java server. (#25405)

Note #25403 tracking whether this is in fact the right fix.
project-chip · Jul 25, 2023 · 1081651 · 1081651
1 parent 4c226fd
commit 1081651
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/app/server/java/BUILD.gn b/src/app/server/java/BUILD.gn
@@ -43,6 +43,8 @@ static_library("jni") {
   ]
 
   public_configs = [ "${chip_root}/src:includes" ]
+
+  cflags = [ "-Wconversion" ]
 }
 
 android_library("java") {

diff --git a/src/app/server/java/ChipFabricProvider-JNI.cpp b/src/app/server/java/ChipFabricProvider-JNI.cpp
@@ -99,7 +99,7 @@ CHIP_ERROR ReadFabricList(JNIEnv * env, jobject & self)
         VerifyOrExit(jlabel != nullptr, err = CHIP_JNI_ERROR_FIELD_NOT_FOUND);
 
         env->SetIntField(jFabric, jvendorId, fabricInfo.GetVendorId());
-        env->SetLongField(jFabric, jnodeId, fabricInfo.GetNodeId());
+        env->SetLongField(jFabric, jnodeId, static_cast<jlong>(fabricInfo.GetNodeId()));
         env->SetShortField(jFabric, jfabricIndex, fabricInfo.GetFabricIndex());
         UtfString jLabelStr(env, fabricInfo.GetFabricLabel());
         env->SetObjectField(jFabric, jlabel, jLabelStr.jniValue());
-Original file line number
+Diff line change
@@ Expand Up / @@ -43,6 +43,8 @@ static_library("jni") { @@
       ]
       public_configs = [ "${chip_root}/src:includes" ]
+      cflags = [ "-Wconversion" ]
     }
     android_library("java") {
@@ Expand Down @@