Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable -Wconversion in the java server. #25405

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

Note #25403 tracking whether this is in fact the right fix.

Note project-chip#25403
tracking whether this is in fact the right fix.
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

PR #25405: Size comparison from e434c6a to 30d57ca

Increases (3 builds for bl702, cc13x2_26x2, qpg)
platform target config section e434c6a 30d57ca change % change
bl702 lighting-app bl702+rpc .debug_info 45013159 45013160 1 0.0
.text 1030920 1030922 2 0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read/write) 171448 171456 8 0.0
qpg lighting-app qpg6105+debug (read/write) 1151676 1151684 8 0.0
.text 598772 598780 8 0.0
Decreases (4 builds for bl602, cc13x2_26x2, cc32xx)
platform target config section e434c6a 30d57ca change % change
bl602 lighting-app bl602 .text 1026862 1026860 -2 -0.0
bl602+rpc .text 1057796 1057794 -2 -0.0
cc13x2_26x2 lock-ftd LP_CC2652R7 (read only) 676991 676983 -8 -0.0
.text 599800 599792 -8 -0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 2026292 20262923 -1 -0.0
Full report (19 builds for bl602, bl702, cc13x2_26x2, cc32xx, k32w, linux, qpg)
platform target config section e434c6a 30d57ca change % change
bl602 lighting-app bl602 (read/write) 1350806 1350806 0 0.0
.bss 94690 94690 0 0.0
.data 9744 9744 0 0.0
.text 1026862 1026860 -2 -0.0
bl602+rpc (read/write) 1396254 1396254 0 0.0
.bss 102738 102738 0 0.0
.data 10136 10136 0 0.0
.text 1057796 1057794 -2 -0.0
bl702 lighting-app bl702 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1189075 1189075 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 69785 69785 0 0.0
.bss_psram 30064 30064 0 0.0
.comment 48 48 0 0.0
.data 4072 4072 0 0.0
.debug_abbrev 1551870 1551870 0 0.0
.debug_aranges 134304 134304 0 0.0
.debug_frame 492456 492456 0 0.0
.debug_info 40601128 40601128 0 0.0
.debug_line 5278983 5278983 0 0.0
.debug_loc 3418290 3418290 0 0.0
.debug_ranges 372480 372480 0 0.0
.debug_str 3580726 3580726 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 107904 107904 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 574866 574866 0 0.0
.symtab 173744 173744 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 956150 956150 0 0.0
bl702+rpc 0 0 0 0.0
(read only) 3358 3358 0 0.0
(read/write) 1279055 1279055 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 292 292 0 0.0
.bss 77833 77833 0 0.0
.bss_psram 30320 30320 0 0.0
.comment 48 48 0 0.0
.data 4616 4616 0 0.0
.debug_abbrev 1700065 1700065 0 0.0
.debug_aranges 142544 142544 0 0.0
.debug_frame 520144 520144 0 0.0
.debug_info 45013159 45013160 1 0.0
.debug_line 5677745 5677745 0 0.0
.debug_loc 3614914 3614914 0 0.0
.debug_ranges 396256 396256 0 0.0
.debug_str 3984263 3984263 0 0.0
.hbn 536 536 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 122016 122016 0 0.0
.rsvd 2960 2960 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 635883 635883 0 0.0
.symtab 192080 192080 0 0.0
.tcm_data 36 36 0 0.0
.tcmcode 3358 3358 0 0.0
.text 1030920 1030922 2 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 680743 680743 0 0.0
(read/write) 170328 170328 0 0.0
.bss 80764 80764 0 0.0
.data 3352 3352 0 0.0
.rodata 88527 88527 0 0.0
.text 591900 591900 0 0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 643887 643887 0 0.0
(read/write) 157432 157432 0 0.0
.bss 79964 79964 0 0.0
.data 3352 3352 0 0.0
.rodata 78399 78399 0 0.0
.text 565168 565168 0 0.0
lock-ftd LP_CC2652R7 (read only) 676991 676983 -8 -0.0
(read/write) 171448 171456 8 0.0
.bss 78220 78220 0 0.0
.data 3316 3316 0 0.0
.rodata 76711 76711 0 0.0
.text 599800 599792 -8 -0.0
lock-mtd LP_CC2652R7 (read only) 663739 663739 0 0.0
(read/write) 179956 179956 0 0.0
.bss 73476 73476 0 0.0
.data 3316 3316 0 0.0
.rodata 103523 103523 0 0.0
.text 559736 559736 0 0.0
pump-app LP_CC2652R7 (read only) 690195 690195 0 0.0
(read/write) 158988 158988 0 0.0
.bss 78196 78196 0 0.0
.data 3280 3280 0 0.0
.rodata 91083 91083 0 0.0
.text 598632 598632 0 0.0
pump-controller-app LP_CC2652R7 (read only) 675147 675147 0 0.0
(read/write) 174172 174172 0 0.0
.bss 78332 78332 0 0.0
.data 3304 3304 0 0.0
.rodata 86971 86971 0 0.0
.text 587696 587696 0 0.0
shell LP_CC2652R7 (read only) 672198 672198 0 0.0
(read/write) 180944 180944 0 0.0
.bss 82836 82836 0 0.0
.data 3348 3348 0 0.0
.rodata 85430 85430 0 0.0
.text 586456 586456 0 0.0
cc32xx lock CC3235SF_LAUNCHXL 0 0 0 0.0
(read only) 643465 643465 0 0.0
(read/write) 203688 203688 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 197088 197088 0 0.0
.comment 194 194 0 0.0
.data 1480 1480 0 0.0
.debug_abbrev 930213 930213 0 0.0
.debug_aranges 87336 87336 0 0.0
.debug_frame 300024 300024 0 0.0
.debug_info 2026292 20262923 -1 -0.0
.debug_line 2657815 2657815 0 0.0
.debug_loc 2800026 2800026 0 0.0
.debug_ranges 282240 282240 0 0.0
.debug_str 3023883 3023883 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 105929 105929 0 0.0
.shstrtab 232 232 0 0.0
.stab 204 204 0 0.0
.stabstr 441 441 0 0.0
.stack 2048 2048 0 0.0
.strtab 378514 378514 0 0.0
.symtab 256560 256560 0 0.0
.text 535412 535412 0 0.0
k32w contact k32w0+release (read/write) 671068 671068 0 0.0
.bss 65276 65276 0 0.0
.data 2204 2204 0 0.0
.text 572188 572188 0 0.0
light k32w0+release (read/write) 670120 670120 0 0.0
.bss 64948 64948 0 0.0
.data 2192 2192 0 0.0
.text 571580 571580 0 0.0
lock k32w0+release (read/write) 626564 626564 0 0.0
.bss 63084 63084 0 0.0
.data 2136 2136 0 0.0
.text 546328 546328 0 0.0
linux chip-tool-ipv6only arm64 (read only) 12138116 12138116 0 0.0
(read/write) 733448 733448 0 0.0
.bss 34296 34296 0 0.0
.data 3008 3008 0 0.0
.data.rel.ro 675552 675552 0 0.0
.dynamic 560 560 0 0.0
.got 15376 15376 0 0.0
.init 24 24 0 0.0
.init_array 216 216 0 0.0
.rodata 587140 587140 0 0.0
.text 9810356 9810356 0 0.0
thermostat-no-ble arm64 (read only) 2519284 2519284 0 0.0
(read/write) 145208 145208 0 0.0
.bss 56344 56344 0 0.0
.data 1784 1784 0 0.0
.data.rel.ro 77688 77688 0 0.0
.dynamic 560 560 0 0.0
.got 5336 5336 0 0.0
.init 24 24 0 0.0
.init_array 432 432 0 0.0
.rodata 150704 150704 0 0.0
.text 2106272 2106272 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1151676 1151684 8 0.0
.bss 99804 99804 0 0.0
.data 852 852 0 0.0
.text 598772 598780 8 0.0
lock-app qpg6105+debug (read/write) 1118892 1118892 0 0.0
.bss 96292 96292 0 0.0
.data 864 864 0 0.0
.text 565992 565992 0 0.0

@andy31415 andy31415 merged commit 2240c70 into project-chip:master Mar 2, 2023
@bzbarsky-apple bzbarsky-apple deleted the enable-conversion-java-server branch March 4, 2023 03:11
lecndav pushed a commit to lecndav/connectedhomeip that referenced this pull request Mar 22, 2023
Note project-chip#25403
tracking whether this is in fact the right fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants