-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check the onboarding payload code type in MTROnboardingPayloadParser #22348
Merged
bzbarsky-apple
merged 1 commit into
project-chip:master
from
nivi-apple:mtrpayloadparser_check_type
Sep 2, 2022
Merged
Check the onboarding payload code type in MTROnboardingPayloadParser #22348
bzbarsky-apple
merged 1 commit into
project-chip:master
from
nivi-apple:mtrpayloadparser_check_type
Sep 2, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nivi-apple
force-pushed
the
mtrpayloadparser_check_type
branch
from
September 1, 2022 19:00
3397564
to
25eb7ea
Compare
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda and
mrjerryjohns
September 1, 2022 19:00
pullapprove
bot
requested review from
msandstedt,
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
September 1, 2022 19:00
bzbarsky-apple
approved these changes
Sep 1, 2022
Fast-tracking platform-specific change. |
PR #22348: Size comparison from e9984f8 to 25eb7ea Increases (3 builds for cc13x2_26x2, esp32, qpg)
Decreases (5 builds for cc13x2_26x2, esp32, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
andy31415
approved these changes
Sep 1, 2022
nivi-apple
force-pushed
the
mtrpayloadparser_check_type
branch
from
September 1, 2022 20:34
25eb7ea
to
523e5d3
Compare
PR #22348: Size comparison from 0f0e1e9 to 523e5d3 Increases (4 builds for bl602, cc13x2_26x2, telink)
Decreases (6 builds for cc13x2_26x2, esp32, k32w, psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
Change overview
Do not pass code type to setupPayloadForOnboardingPayload. Instead just get the code type from the payload itself.
Testing
How was this tested? (at least one bullet point required)
Built darwin framework