Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTROnboardingPayloadParser needs to check the code type #20311

Closed
krypton36 opened this issue Jul 5, 2022 · 1 comment · Fixed by #22024 or #22348
Closed

MTROnboardingPayloadParser needs to check the code type #20311

krypton36 opened this issue Jul 5, 2022 · 1 comment · Fixed by #22024 or #22348
Assignees

Comments

@krypton36
Copy link
Contributor

krypton36 commented Jul 5, 2022

Problem

When using MTROnboardingPayloadParser API in matter framework, you have to determine which type it is before hand. MTROnboardingPayloadParser should accept any payload and determine the payload type for caller convenience.

Proposed Solution

In MTROnboardingPayloadParser determine if code type is MTROnboardingPayloadTypeQRCode, MTROnboardingPayloadTypeManualCode, MTROnboardingPayloadTypeNFC, or MTROnboardingPayloadTypeAdmin.

@bzbarsky-apple
Copy link
Contributor

API surface, so 1.0 if we're going to do this.

@bzbarsky-apple bzbarsky-apple changed the title CHIPOnboardingPayloadParser needs to check the code type MTROnboardingPayloadParser needs to check the code type Jul 11, 2022
@woody-apple woody-apple self-assigned this Jul 19, 2022
@woody-apple woody-apple assigned nivi-apple and unassigned woody-apple Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants