-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add payload parser to darwin framework tool #19735
Merged
tcarmelveilleux
merged 1 commit into
project-chip:master
from
krypton36:AddPayloadParserToDarwinFrameworkTool
Jul 6, 2022
Merged
Add payload parser to darwin framework tool #19735
tcarmelveilleux
merged 1 commit into
project-chip:master
from
krypton36:AddPayloadParserToDarwinFrameworkTool
Jul 6, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
msandstedt and
rgoliver
June 17, 2022 19:48
pullapprove
bot
requested review from
robszewczyk,
sagar-apple,
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
June 17, 2022 19:48
krypton36
force-pushed
the
AddPayloadParserToDarwinFrameworkTool
branch
from
June 17, 2022 19:54
6c74ebd
to
513010e
Compare
PR #19735: Size comparison from 147cab2 to 513010e Increases (3 builds for cc13x2_26x2, esp32, telink)
Decreases (2 builds for cc13x2_26x2, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
bzbarsky-apple
approved these changes
Jun 17, 2022
examples/darwin-framework-tool/commands/payload/SetupPayloadParseCommand.mm
Show resolved
Hide resolved
examples/darwin-framework-tool/commands/payload/SetupPayloadParseCommand.mm
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Jun 17, 2022
PR #19735: Size comparison from 1381c8e to e7b3bfb Increases (2 builds for cc13x2_26x2, cyw30739)
Decreases (2 builds for cc13x2_26x2, nrfconnect)
Full report (39 builds for cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
|
PR #19735: Size comparison from 6e6892a to 3ef4509 Increases (4 builds for cc13x2_26x2, nrfconnect, telink)
Decreases (2 builds for cc13x2_26x2, esp32)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
force-pushed
the
AddPayloadParserToDarwinFrameworkTool
branch
from
July 2, 2022 16:49
3ef4509
to
b91a2ad
Compare
PR #19735: Size comparison from 19d0f52 to b91a2ad Increases (3 builds for cc13x2_26x2, efr32, telink)
Decreases (1 build for cc13x2_26x2)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
krypton36
force-pushed
the
AddPayloadParserToDarwinFrameworkTool
branch
from
July 5, 2022 15:14
b91a2ad
to
28382fb
Compare
PR #19735: Size comparison from e791ff3 to 28382fb Increases (3 builds for k32w, telink)
Full report (41 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Darwin-framework-tool does not have a payload parser to demonstrate that a commissioner implemented using CHIP.framework can indeed parse out the Vendor ID and check to see if it is valid.
Change overview
Testing