-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Binding cluster requirement in device type to align with the spec #22286
Merged
andy31415
merged 4 commits into
project-chip:master
from
yufengwangca:pr/devicetype/binding
Sep 1, 2022
Merged
Update Binding cluster requirement in device type to align with the spec #22286
andy31415
merged 4 commits into
project-chip:master
from
yufengwangca:pr/devicetype/binding
Sep 1, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns and
msandstedt
August 30, 2022 19:16
pullapprove
bot
requested review from
mspang,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yunhanw-google
August 30, 2022 19:16
PR #22286: Size comparison from d47c8f7 to f3d17b7 Increases (5 builds for bl602, esp32, psoc6, telink)
Decreases (2 builds for psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #22286: Size comparison from 04eeef1 to 1f7ab76 Increases (4 builds for cc13x2_26x2, esp32, psoc6)
Decreases (7 builds for bl602, cc13x2_26x2, nrfconnect, qpg, telink)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Accepted: compatibility issue, does not actually change coresdk code. |
PR #22286: Size comparison from 4e01cee to 42b03a8 Increases (2 builds for bl602, esp32)
Decreases (3 builds for psoc6)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bzbarsky-apple
approved these changes
Aug 31, 2022
andy31415
approved these changes
Sep 1, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…pec (project-chip#22286) * Revert "Update Binding cluster requirement in device type to align with the spec (project-chip#22119)" This reverts commit 150d741. * Update Binding cluster requirement in device type to align with the spec * Include Binding cluster to all-cluster-app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
What is being fixed? Examples:
That is, for any given device type the "Simple & Client" expression evaluates to a specific boolean, except if the device type has optional client clusters.
Change overview
Update Binding cluster requirement in device type to align with the spec
Testing
How was this tested? (at least one bullet point required)