Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect binding cluster conformance in device types #22207

Closed
bzbarsky-apple opened this issue Aug 27, 2022 · 1 comment · Fixed by #22286
Closed

Fix incorrect binding cluster conformance in device types #22207

bzbarsky-apple opened this issue Aug 27, 2022 · 1 comment · Fixed by #22286
Assignees
Labels
spec Mismatch between spec and implementation V1.0

Comments

@bzbarsky-apple
Copy link
Contributor

Problem

#22119 introduced incorrect Binding cluster bits in various device types.

For example, in the "Matter On/Off Light Switch" device type, the Binding cluster server is required per spec, but that PR made it optional.

Proposed Solution

Fix things to actually follow the spec.

@bzbarsky-apple bzbarsky-apple added V1.0 spec Mismatch between spec and implementation labels Aug 27, 2022
@bzbarsky-apple
Copy link
Contributor Author

And for a bunch of other device types it's excluded, but was made allowed in #22119. So it's possible that the right fix is to revert #22119.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec Mismatch between spec and implementation V1.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants