-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EFR32: PSA crypto validations fixed. #22259
Merged
mspang
merged 1 commit into
project-chip:master
from
rcasallas-silabs:bugfix/efr32_crypto_validations
Aug 31, 2022
Merged
EFR32: PSA crypto validations fixed. #22259
mspang
merged 1 commit into
project-chip:master
from
rcasallas-silabs:bugfix/efr32_crypto_validations
Aug 31, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple and
kpschoedel
August 30, 2022 12:32
pullapprove
bot
requested review from
LuDuda,
mrjerryjohns,
msandstedt,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
August 30, 2022 12:32
PR #22259: Size comparison from 708685f to 63eba43 Increases (7 builds for efr32, esp32, telink)
Decreases (2 builds for psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
selissia
approved these changes
Aug 30, 2022
jmartinez-silabs
approved these changes
Aug 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgoliver PTAL
1.0 accepted: platform specific change. |
rcasallas-silabs
force-pushed
the
bugfix/efr32_crypto_validations
branch
from
August 31, 2022 08:55
63eba43
to
eb76f19
Compare
PR #22259: Size comparison from 0a36d9f to eb76f19 Increases (9 builds for cc13x2_26x2, efr32, esp32, psoc6)
Decreases (6 builds for bl602, cc13x2_26x2, psoc6, qpg)
Full report (34 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
rgoliver
approved these changes
Aug 31, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Multiple unit tests fail due to validation issues.
Change overview
Testing
Tested on BRD4164A (MG12) and BRD4186A (MG24).