Skip to content

Commit

Permalink
Fix chip-tool remove-keyset command. (#27676)
Browse files Browse the repository at this point in the history
We were returning without calling SetCommandExitStatus if removing group keys
_succeeded_, which is backwards.

Fixes #27600
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Oct 15, 2023
1 parent e4587b4 commit 3655093
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions examples/chip-tool/commands/group/Commands.h
Original file line number Diff line number Diff line change
Expand Up @@ -332,10 +332,7 @@ class RemoveKeySet : public CHIPCommand
}
iter->Release();

if (err == CHIP_NO_ERROR)
{
return err;
}
ReturnErrorOnFailure(err);
ReturnErrorOnFailure(groupDataProvider->RemoveKeySet(fabricIndex, keysetId));

SetCommandExitStatus(CHIP_NO_ERROR);
Expand Down

0 comments on commit 3655093

Please sign in to comment.