-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update DRLK feature PICS to correct format #22249
Merged
tcarmelveilleux
merged 2 commits into
project-chip:master
from
tcarmelveilleux:fix-drlk-pics
Aug 30, 2022
Merged
Update DRLK feature PICS to correct format #22249
tcarmelveilleux
merged 2 commits into
project-chip:master
from
tcarmelveilleux:fix-drlk-pics
Aug 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- TC-DRLK-XX use wrong values for two pics (see project-chip#22248) This PR renames the PICS and also properly implement TC-DRLK-1.1 feature bits check to match test plan Fixes project-chip#22248 Testing done: - Tests in CI still pass after regen
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kpschoedel,
lazarkov and
LuDuda
August 29, 2022 21:11
pullapprove
bot
requested review from
mlepage-google,
mrjerryjohns,
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
selissia,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
August 29, 2022 21:11
PR #22249: Size comparison from 6329339 to 43818da Increases (6 builds for cc13x2_26x2, linux, psoc6, telink)
Decreases (4 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
PR #22249: Size comparison from 6329339 to e07d01c Increases (3 builds for linux, psoc6)
Decreases (2 builds for esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
raju-apple
approved these changes
Aug 30, 2022
jepenven-silabs
approved these changes
Aug 30, 2022
yunhanw-google
approved these changes
Aug 30, 2022
github-actions bot
pushed a commit
that referenced
this pull request
Aug 30, 2022
* Update DRLK feature PICS to correct format - TC-DRLK-XX use wrong values for two pics (see #22248) This PR renames the PICS and also properly implement TC-DRLK-1.1 feature bits check to match test plan Fixes #22248 Testing done: - Tests in CI still pass after regen * Fix CI PICS values to match existing application
andy31415
pushed a commit
that referenced
this pull request
Aug 31, 2022
* Update DRLK feature PICS to correct format - TC-DRLK-XX use wrong values for two pics (see #22248) This PR renames the PICS and also properly implement TC-DRLK-1.1 feature bits check to match test plan Fixes #22248 Testing done: - Tests in CI still pass after regen * Fix CI PICS values to match existing application Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
* Update DRLK feature PICS to correct format - TC-DRLK-XX use wrong values for two pics (see project-chip#22248) This PR renames the PICS and also properly implement TC-DRLK-1.1 feature bits check to match test plan Fixes project-chip#22248 Testing done: - Tests in CI still pass after regen * Fix CI PICS values to match existing application
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Change overview
This PR renames the PICS and also properly implement TC-DRLK-1.1
feature bits check to match test plan
Fixes #22248
Testing