-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EFR32] fix brd2703a build issue #22242
Merged
jepenven-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:fix_brd2703b
Aug 30, 2022
Merged
[EFR32] fix brd2703a build issue #22242
jepenven-silabs
merged 1 commit into
project-chip:master
from
jmartinez-silabs:fix_brd2703b
Aug 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jtung-apple,
kghost,
kpschoedel,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
August 29, 2022 19:25
pullapprove
bot
requested review from
saurabhst,
selissia,
tecimovic,
tehampson,
turon,
vijs,
vivien-apple,
wbschiller,
woody-apple and
xylophone21
August 29, 2022 19:25
selissia
approved these changes
Aug 29, 2022
PR #22242: Size comparison from b90a934 to 76ad4a5 Increases (5 builds for bl602, nrfconnect, telink)
Full report (11 builds for bl602, k32w, linux, mbed, nrfconnect, telink)
|
jmartinez-silabs
force-pushed
the
fix_brd2703b
branch
from
August 29, 2022 20:13
76ad4a5
to
5d34dbc
Compare
PR #22242: Size comparison from 6329339 to 5d34dbc Increases (4 builds for psoc6, telink)
Decreases (2 builds for esp32, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
tcarmelveilleux
approved these changes
Aug 30, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
release build for brd2703a fails due to some build options
Change overview
Update matter_support submodule that fixes a wrong #ifdef position for some includes of that board.
This PR only affects 1 board of the EFR32 platform and is needed for the full support of that board
Testing
Build lighting app standard and release option for brd2703a. Commission and control with chip-tool