-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESP32] cmake option to set software version and software version string #22229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
August 29, 2022 11:49
pullapprove
bot
added
review - pending
and removed
examples
platform
esp32
config
labels
Aug 29, 2022
shubhamdp
force-pushed
the
esp32_version
branch
from
August 29, 2022 11:51
029ec4e
to
2d6c25f
Compare
PR #22229: Size comparison from 16edce7 to 2d6c25f Decreases (5 builds for k32w, nrfconnect, telink)
Full report (11 builds for bl602, k32w, linux, mbed, nrfconnect, telink)
|
PR #22229: Size comparison from 16edce7 to 6366f44 Increases (1 build for psoc6)
Decreases (3 builds for nrfconnect, psoc6, telink)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
shubhamdp
force-pushed
the
esp32_version
branch
from
August 30, 2022 09:47
0d042e2
to
8e6b224
Compare
PR #22229: Size comparison from 708685f to 8e6b224 Increases (1 build for telink)
Decreases (2 builds for psoc6)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
ESP-IDF lets user set software version string by two ways: Project's CMakeLists.txt file or configuration option. It depends on CONFIG_APP_PROJECT_VER_FROM_CONFIG option so making the same provision for software version number. Also, Reading the software version string from the app description which is set using any one of above method. Setting the default software version as per spec i.e. 0. Setting PROJECT_VER and PROJECT_VER_NUMBER in all the examples
shubhamdp
force-pushed
the
esp32_version
branch
from
August 30, 2022 15:36
128eb8d
to
f85e859
Compare
PR #22229: Size comparison from 9bde9e3 to f85e859 Increases (5 builds for cc13x2_26x2, esp32, telink)
Decreases (5 builds for cc13x2_26x2, esp32, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
dhrishi
approved these changes
Aug 30, 2022
1.0 accepted: platform-specific change, platform owners are gatekeepers here. |
bzbarsky-apple
approved these changes
Aug 31, 2022
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…ing (project-chip#22229) * [ESP32] cmake option to set software version and software version string ESP-IDF lets user set software version string by two ways: Project's CMakeLists.txt file or configuration option. It depends on CONFIG_APP_PROJECT_VER_FROM_CONFIG option so making the same provision for software version number. Also, Reading the software version string from the app description which is set using any one of above method. Setting the default software version as per spec i.e. 0. Setting PROJECT_VER and PROJECT_VER_NUMBER in all the examples * Fix the QEMU tests * Set software version to 0 if not set using cmake or config option * Override GetSoftwareVersion in configuration manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP-IDF lets user set software version string by two ways: Project's
CMakeLists.txt file or configuration option. It depends on
CONFIG_APP_PROJECT_VER_FROM_CONFIG option so making the same provision
for software version number.
Also, Reading the software version string from the app description
which is set using any one of above method.
Setting the default software version as per spec i.e. 0.
Setting PROJECT_VER and PROJECT_VER_NUMBER in all the examples
Problem
Change overview
Please see above
Testing