-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow endpoint ID to be specified when adding content app dynamically #22199
Conversation
PR #22199: Size comparison from 6329339 to ae01dac Increases (4 builds for linux, psoc6)
Decreases (6 builds for bl602, esp32, nrfconnect, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All PRs after the lockdown date (22 Aug) need to be linked with an issue and contain solid 1.0 justification. This includes why this is important for 1.0 and what is the sideffect of not being accepted into 1.0. The bar is higher than "this is a useful change".
Please update summary content.
Accepted: issue linked is marked as accepted patches for 1.0 |
PR #22199: Size comparison from d47c8f7 to f400851 Increases (4 builds for bl602, esp32, linux, psoc6)
Decreases (6 builds for esp32, k32w, nrfconnect, psoc6, telink)
Full report (45 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…project-chip#22199) * Allow endpoint ID sto be specified when adding content app dynamically * Restyled by whitespace * Restyled by clang-format * Review comments... * Restyled by whitespace * Restyled by clang-format * Update content apps array only when adding endpoint succeeds. updated documentation. * Restyled by clang-format Co-authored-by: Restyled.io <[email protected]>
Problem
The content app platform currently does not allow the tv-app to specify the endpoint ID to use. It will be required to manage endpoints across restarts of the app/device
Fixes #22285
Change overview
Add and use a new parameter to the AddContentApp method to accept a desired endpoint ID.
Testing
Manual testing using the tv-casting-app