-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make StartUpColorTemperatureMireds nullable, per spec. #22109
Merged
woody-apple
merged 2 commits into
sve-2
from
cherry-pick-c3fcbc1781c4c9e1e1dc8cf986b20837285c0edb
Aug 24, 2022
Merged
Make StartUpColorTemperatureMireds nullable, per spec. #22109
woody-apple
merged 2 commits into
sve-2
from
cherry-pick-c3fcbc1781c4c9e1e1dc8cf986b20837285c0edb
Aug 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #22109: Size comparison from bdbcb40 to 1e1ac85 Increases (14 builds for bl602, cc13x2_26x2, efr32, esp32, k32w, nrfconnect)
Decreases (3 builds for cc13x2_26x2)
Full report (21 builds for bl602, cc13x2_26x2, efr32, esp32, k32w, mbed, nrfconnect)
|
woody-apple
deleted the
cherry-pick-c3fcbc1781c4c9e1e1dc8cf986b20837285c0edb
branch
August 24, 2022 20:21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21855
Problem
Attribute is not nullable.
Change overview
It should be.
Testing
Examined the generated code.
@jmartinez-silabs