-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make StartUpColorTemperatureMireds nullable, per spec. #21858
Merged
woody-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:make-startup-temp-nullable
Aug 23, 2022
Merged
Make StartUpColorTemperatureMireds nullable, per spec. #21858
woody-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:make-startup-temp-nullable
Aug 23, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bzbarsky-apple
force-pushed
the
make-startup-temp-nullable
branch
from
August 12, 2022 14:40
4dd1025
to
5f4c6a5
Compare
jmartinez-silabs
approved these changes
Aug 12, 2022
PR #21858: Size comparison from 28a21a1 to 5f4c6a5 Increases (27 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
woody-apple
approved these changes
Aug 15, 2022
pullapprove
bot
requested review from
arkq,
Byungjoo-Lee,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
erjiaqing,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
kghost,
lazarkov,
LuDuda and
mrjerryjohns
August 15, 2022 23:52
pullapprove
bot
requested review from
msandstedt,
rgoliver,
robszewczyk,
saurabhst,
tcarmelveilleux,
tehampson,
turon,
vijs,
wbschiller,
xylophone21 and
yufengwangca
August 15, 2022 23:52
PR #21858: Size comparison from e80da23 to 7fb699e Increases (23 builds for bl602, cc13x2_26x2, cyw30739, efr32, linux, nrfconnect, p6)
Decreases (23 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, telink)
Full report (32 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
Aug 17, 2022
PR #21858: Size comparison from 0f9615d to d177e19 Increases (26 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, psoc6, telink)
Decreases (3 builds for cc13x2_26x2)
Full report (41 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
woody-apple
added a commit
that referenced
this pull request
Aug 24, 2022
Fixes #21855 Co-authored-by: Boris Zbarsky <[email protected]> Co-authored-by: Andrei Litvin <[email protected]>
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21855
Problem
Attribute is not nullable.
Change overview
It should be.
Testing
Examined the generated code.
@jmartinez-silabs