Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix] disable lcd in CI lighting_app with RPC build #22052

Merged
merged 5 commits into from
Aug 21, 2022
Merged

[Hotfix] disable lcd in CI lighting_app with RPC build #22052

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c748e0d
Hotfix, disable lcd in CI lighting_app with RPC build
jmartinez-silabs Aug 19, 2022
ad76e1b
oops disable_lcd=true
jmartinez-silabs Aug 19, 2022
9a9510c
missing #ifdef for building without lcd + add is_debug=false for efr3…
jmartinez-silabs Aug 20, 2022
65e8bef
fix strings in build_all_except_host.txt
jmartinez-silabs Aug 20, 2022
c42553b
fix strings again in build_all_except_host.txt
jmartinez-silabs Aug 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/examples-efr32.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
timeout-minutes: 15
run: |
scripts/examples/gn_efr32_example.sh examples/lighting-app/efr32/ out/lighting_app_debug_rpc BRD4161A "is_debug=false" \
'import("//with_pw_rpc.gni")'
disable_lcd=true 'import("//with_pw_rpc.gni")'
.environment/pigweed-venv/bin/python3 scripts/tools/memory/gh_sizes.py efr32 BRD4161A+rpc lighting-app \
out/lighting_app_debug_rpc/BRD4161A/chip-efr32-lighting-example.out /tmp/bloat_reports/
- name: Build example EFR32+WF200 WiFi Lock app for BRD4161A
Expand Down
2 changes: 2 additions & 0 deletions examples/platform/efr32/BaseApplication.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,10 @@ void BaseApplication::ButtonHandler(AppEvent * aEvent)
CancelFunctionTimer();
mFunction = kFunction_NoneSelected;

#ifdef DISPLAY_ENABLED
// TOGGLE QRCode/LCD demo UI
slLCD.ToggleQRCode();
#endif

#ifdef SL_WIFI
if (!ConnectivityMgr().IsWiFiStationProvisioned())
Expand Down
2 changes: 1 addition & 1 deletion scripts/build/builders/efr32.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def __init__(self,
self.extra_gn_options = ['efr32_board="%s"' % board.GnArgName()]

if enable_rpcs:
self.extra_gn_options.append('import("//with_pw_rpc.gni")')
self.extra_gn_options.append('is_debug=false import("//with_pw_rpc.gni")')

if enable_ota_requestor:
self.extra_gn_options.append('chip_enable_ota_requestor=true')
Expand Down
Loading