-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Hotfix] disable lcd in CI lighting_app with RPC build #22052
Merged
jmartinez-silabs
merged 5 commits into
project-chip:master
from
jmartinez-silabs:hotfix_ci
Aug 21, 2022
Merged
[Hotfix] disable lcd in CI lighting_app with RPC build #22052
jmartinez-silabs
merged 5 commits into
project-chip:master
from
jmartinez-silabs:hotfix_ci
Aug 21, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harsha-rajendran,
hawk248,
isiu-apple,
jelderton,
jepenven-silabs,
jtung-apple,
kghost,
lazarkov,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt and
mspang
August 19, 2022 21:44
pullapprove
bot
requested review from
selissia,
tcarmelveilleux,
tecimovic,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21 and
yufengwangca
August 19, 2022 21:44
PR #22052: Size comparison from 056f016 to ad76e1b Increases (3 builds for cc13x2_26x2, k32w, psoc6)
Decreases (5 builds for cc13x2_26x2, esp32, psoc6, telink)
Full report (38 builds for bl602, cc13x2_26x2, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
…2 rpc builds when using build_examples.py
PR #22052: Size comparison from 056f016 to 9a9510c Increases (2 builds for k32w, linux)
Decreases (2 builds for telink)
Full report (11 builds for bl602, k32w, linux, mbed, nrfconnect, telink)
|
jepenven-silabs
approved these changes
Aug 20, 2022
tcarmelveilleux
approved these changes
Aug 20, 2022
PR #22052: Size comparison from 056f016 to c42553b Increases above 0.2%:
Increases (9 builds for cc13x2_26x2, esp32, k32w, linux, psoc6)
Decreases (7 builds for bl602, cc13x2_26x2, cyw30739, efr32, psoc6, telink)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
isiu-apple
pushed a commit
to isiu-apple/connectedhomeip
that referenced
this pull request
Sep 16, 2022
…22052) * Hotfix, disable lcd in CI lighting_app with RPC build * oops disable_lcd=true * missing #ifdef for building without lcd + add is_debug=false for efr32 rpc builds when using build_examples.py * fix strings in build_all_except_host.txt * fix strings again in build_all_except_host.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Lighting app with RPC build runs out of flash
Change overview
Disable the LCD usage for that particular build
Testing
build the app with the same arguments has CI