-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve IM PrettyPrint #21987
Improve IM PrettyPrint #21987
Conversation
PR #21987: Size comparison from c037fc2 to a3f93b2 Increases (2 builds for cc13x2_26x2, nrfconnect)
Decreases (17 builds for bl602, cc13x2_26x2, esp32, linux)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
a3f93b2
to
324ce1f
Compare
PR #21987: Size comparison from b1f2fc7 to 324ce1f Increases (2 builds for cc13x2_26x2, telink)
Decreases (20 builds for cc13x2_26x2, esp32, linux, psoc6)
Full report (43 builds for bl602, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, telink)
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
This stale pull request has been automatically closed. Thank you for your contributions. |
324ce1f
to
ed7164e
Compare
PR #21987: Size comparison from 26dab6c to ed7164e Increases (6 builds for bl602, cc13x2_26x2, telink)
Decreases (13 builds for bl702, cc13x2_26x2, esp32, linux, psoc6, telink)
Full report (36 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, psoc6, qpg, telink)
|
ed7164e
to
22331c0
Compare
PR #21987: Size comparison from 4675695 to 22331c0 Increases (8 builds for bl602, bl702, cc13x2_26x2, telink)
Decreases (15 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Full report (38 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
22331c0
to
20b686a
Compare
PR #21987: Size comparison from 8e63ca5 to 20b686a Decreases (2 builds for linux)
Full report (2 builds for linux)
|
aff8d10
to
afc28f8
Compare
PR #21987: Size comparison from 887822a to e98d101 Increases (4 builds for bl702, cc13x2_26x2, cyw30739, nrfconnect)
Decreases (25 builds for bl602, bl702, esp32, k32w, linux, psoc6, telink)
Full report (49 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
--Remove the necessary elemnt check in im pretty print --Rename CheckSchemaValidity to PrettyPrint --Don't process the returned error for prettyPrint in IM client/server code
e98d101
to
1fe5d5f
Compare
PR #21987: Size comparison from 361c74d to 1fe5d5f Increases (3 builds for bl702, cc13x2_26x2, telink)
Decreases (15 builds for bl702, cc13x2_26x2, esp32, linux, nrfconnect, psoc6, telink)
Full report (40 builds for bl602, bl702, cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
…1987) --Remove the necessary elemnt check in im pretty print --Rename CheckSchemaValidity to PrettyPrint --Don't process the returned error for prettyPrint in IM client/server code
…1987) --Remove the necessary elemnt check in im pretty print --Rename CheckSchemaValidity to PrettyPrint --Don't process the returned error for prettyPrint in IM client/server code
Problem
#21698
CHIP_CONFIG_IM_ENABLE_SCHEMA_CHECK is only enabled in linux/darwin platform, there is extra element check inside CHIP_CONFIG_IM_ENABLE_SCHEMA_CHECK, which mean we are testing in CI is likely not what we are shipping on devices.
Change overview
--Remove minimum element check in CHIP_CONFIG_IM_ENABLE_SCHEMA_CHECK, then the element check would be unified/processed into same code path under IM client/handler with or without CHIP_CONFIG_IM_ENABLE_SCHEMA_CHECK.
--Rename CHIP_CONFIG_IM_ENABLE_SCHEMA_CHECK to CHIP_CONFIG_IM_PRETTY_PRINT
--Rename CheckSchemaValidity to PrettyPrint
--In IM client/server code, don't process the error from PrettyPrint.
Testing
The existing test covers.