Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement 2 missing tests in FabricTable #21948

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Implement 2 missing tests in FabricTable #21948

merged 1 commit into from
Aug 17, 2022

Conversation

tcarmelveilleux
Copy link
Contributor

Problem

Change overview

  • This PR implements TestAddMultipleSameRootDifferentFabricId and
    TestInvalidChaining

Fixes #21946
Fixes #21947

Testing

  • Added 2 new unit tests, both pass
  • Did some messing about to make assertions fail on purpose
    and validated the the wrong behavior was not passing

@tcarmelveilleux
Implement 2 missing tests in FabricTable
a5ec099 
- In project-chip#19819, TODOs were left for a couple tests of
  things "anecdotally" known to work, or tested outside
  of SDK, but not tested yet in official SDK.

- This PR implements TestAddMultipleSameRootDifferentFabricId and
  TestInvalidChaining

Fixes project-chip#21946
Fixes project-chip#21947

Testing done:
- Added 2 new unit tests, both pass
- Did some messing about to make assertions fail on purpose
  and validated the the wrong behavior was not passing
@github-actions
Copy link

github-actions bot commented Aug 17, 2022 •
edited
Loading

PR #21948: Size comparison from 06457ae to a5ec099

Increases (4 builds for bl602, cc13x2_26x2, efr32, nrfconnect)
platform target config section 06457ae a5ec099 change % change
bl602 lighting-app bl602+rpc .text 1082784 1082788 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read/write) 179116 179124 8 0.0
efr32 lock-app BRD4161A+wf200 (read/write) 1139220 1139236 16 0.0
.text 991648 991664 16 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 text 814072 814076 4 0.0
Decreases (2 builds for cc13x2_26x2, telink)
platform target config section 06457ae a5ec099 change % change
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672363 672355 -8 -0.0
.text 583300 583292 -8 -0.0
telink lighting-app tlsr9518adk80d text 589394 589392 -2 -0.0
Full report (30 builds for bl602, cc13x2_26x2, cyw30739, efr32, k32w, linux, mbed, nrfconnect, p6, telink)
platform target config section 06457ae a5ec099 change % change
bl602 lighting-app bl602 (read/write) 1383458 1383458 0 0.0
.bss 119874 119874 0 0.0
.data 4480 4480 0 0.0
.text 1051028 1051028 0 0.0
bl602+rpc (read/write) 1428970 1428970 0 0.0
.bss 127314 127314 0 0.0
.data 4600 4600 0 0.0
.text 1082784 1082788 4 0.0
cc13x2_26x2 all-clusters-app LP_CC2652R7 (read only) 672363 672355 -8 -0.0
(read/write) 179116 179124 8 0.0
.bss 74372 74372 0 0.0
.data 3372 3372 0 0.0
.rodata 88747 88747 0 0.0
.text 583300 583292 -8 -0.0
all-clusters-minimal-app LP_CC2652R7 (read only) 637747 637747 0 0.0
(read/write) 157948 157948 0 0.0
.bss 73660 73660 0 0.0
.data 3372 3372 0 0.0
.rodata 77979 77979 0 0.0
.text 559444 559444 0 0.0
lock-ftd LP_CC2652R7 (read only) 674079 674079 0 0.0
(read/write) 167616 167616 0 0.0
.bss 71476 71476 0 0.0
.data 3296 3296 0 0.0
.rodata 76671 76671 0 0.0
.text 596928 596928 0 0.0
lock-mtd LP_CC2652R7 (read only) 656815 656815 0 0.0
(read/write) 180568 180568 0 0.0
.bss 67164 67164 0 0.0
.data 3296 3296 0 0.0
.rodata 101759 101759 0 0.0
.text 554576 554576 0 0.0
pump-app LP_CC2652R7 (read only) 684751 684751 0 0.0
(read/write) 157752 157752 0 0.0
.bss 71516 71516 0 0.0
.data 3296 3296 0 0.0
.rodata 89959 89959 0 0.0
.text 594308 594308 0 0.0
pump-controller-app LP_CC2652R7 (read only) 669243 669243 0 0.0
(read/write) 173380 173380 0 0.0
.bss 71636 71636 0 0.0
.data 3292 3292 0 0.0
.rodata 85515 85515 0 0.0
.text 583248 583248 0 0.0
shell LP_CC2652R7 (read only) 665046 665046 0 0.0
(read/write) 181952 181952 0 0.0
.bss 76692 76692 0 0.0
.data 3376 3376 0 0.0
.rodata 85694 85694 0 0.0
.text 579036 579036 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 586014 586014 0 0.0
.app_xip_area 462680 462680 0 0.0
.bss 65768 65768 0 0.0
.data 744 744 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 591830 591830 0 0.0
.app_xip_area 463712 463712 0 0.0
.bss 70552 70552 0 0.0
.data 748 748 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor-no-progress-logging cyw930739m2evb_01 (read/write) 598970 598970 0 0.0
.app_xip_area 476356 476356 0 0.0
.bss 65080 65080 0 0.0
.data 716 716 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A (read/write) 1100580 1100580 0 0.0
.bss 132988 132988 0 0.0
.data 2068 2068 0 0.0
.text 965500 965500 0 0.0
BRD4161A+rpc (read/write) 1154832 1154832 0 0.0
.bss 149676 149676 0 0.0
.data 2280 2280 0 0.0
.text 1002856 1002856 0 0.0
BRD4161A+rs911x (read/write) 989768 989768 0 0.0
.bss 162312 162312 0 0.0
.data 2056 2056 0 0.0
.text 825380 825380 0 0.0
lock-app BRD4161A+wf200 (read/write) 1139220 1139236 16 0.0
.bss 145488 145488 0 0.0
.data 2064 2064 0 0.0
.text 991648 991664 16 0.0
window-app BRD4161A (read/write) 1092036 1092036 0 0.0
.bss 134428 134428 0 0.0
.data 2096 2096 0 0.0
.text 955492 955492 0 0.0
k32w light k32w0+release (read/write) 645028 645028 0 0.0
.bss 69816 69816 0 0.0
.data 2044 2044 0 0.0
.text 570440 570440 0 0.0
lock k32w0+release (read/write) 702580 702580 0 0.0
.bss 70288 70288 0 0.0
.data 2052 2052 0 0.0
.text 627512 627512 0 0.0
linux chip-tool-ipv6only arm64 (read only) 10172764 10172764 0 0.0
(read/write) 698657 698657 0 0.0
.bss 33297 33297 0 0.0
.data 3272 3272 0 0.0
.data.rel.ro 643408 643408 0 0.0
.dynamic 560 560 0 0.0
.got 13720 13720 0 0.0
.init 24 24 0 0.0
.init_array 192 192 0 0.0
.rodata 489884 489884 0 0.0
.text 8045924 8045924 0 0.0
thermostat-no-ble arm64 (read only) 2356996 2356996 0 0.0
(read/write) 141825 141825 0 0.0
.bss 55345 55345 0 0.0
.data 1672 1672 0 0.0
.data.rel.ro 75984 75984 0 0.0
.dynamic 560 560 0 0.0
.got 5048 5048 0 0.0
.init 24 24 0 0.0
.init_array 408 408 0 0.0
.rodata 140524 140524 0 0.0
.text 1978752 1978752 0 0.0
mbed lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2454264 2454264 0 0.0
.bss 214660 214660 0 0.0
.data 5872 5872 0 0.0
.text 1416908 1416908 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read/write) 1179539 1179539 0 0.0
bss 143343 143343 0 0.0
rodata 143268 143268 0 0.0
text 814072 814076 4 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read/write) 1159415 1159415 0 0.0
bss 142580 142580 0 0.0
rodata 134944 134944 0 0.0
text 803064 803064 0 0.0
p6 all-clusters-app default (read only) 881400 881400 0 0.0
(read/write) 1698868 1698868 0 0.0
.bss 149288 149288 0 0.0
.data 2656 2656 0 0.0
.text 1538536 1538536 0 0.0
all-clusters-minimal-app default (read only) 882120 882120 0 0.0
(read/write) 1642876 1642876 0 0.0
.bss 148568 148568 0 0.0
.data 2656 2656 0 0.0
.text 1483264 1483264 0 0.0
light-app default (read only) 890464 890464 0 0.0
(read/write) 1560148 1560148 0 0.0
.bss 140432 140432 0 0.0
.data 2448 2448 0 0.0
.text 1408880 1408880 0 0.0
lock-app default (read only) 885968 885968 0 0.0
(read/write) 1597428 1597428 0 0.0
.bss 144912 144912 0 0.0
.data 2464 2464 0 0.0
.text 1441664 1441664 0 0.0
telink light-switch-app tlsr9518adk80d (read/write) 808344 808344 0 0.0
bss 71064 71064 0 0.0
noinit 43488 43488 0 0.0
text 571304 571304 0 0.0
lighting-app tlsr9518adk80d (read/write) 830280 830280 0 0.0
bss 71920 71920 0 0.0
noinit 43488 43488 0 0.0
text 589394 589392 -2 -0.0

@andy31415 andy31415 enabled auto-merge (squash) August 17, 2022 14:39
@andy31415 andy31415 merged commit 69d3d59 into project-chip:master Aug 17, 2022
isiu-apple pushed a commit to isiu-apple/connectedhomeip that referenced this pull request Sep 16, 2022
@tcarmelveilleux @isiu-apple
Implement 2 missing tests in FabricTable (project-chip#21948)
206ad9f 
- In project-chip#19819, TODOs were left for a couple tests of
  things "anecdotally" known to work, or tested outside
  of SDK, but not tested yet in official SDK.

- This PR implements TestAddMultipleSameRootDifferentFabricId and
  TestInvalidChaining

Fixes project-chip#21946
Fixes project-chip#21947

Testing done:
- Added 2 new unit tests, both pass
- Did some messing about to make assertions fail on purpose
  and validated the the wrong behavior was not passing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msandstedt msandstedt msandstedt approved these changes

@andy31415 andy31415 andy31415 approved these changes

@anush-apple anush-apple Awaiting requested review from anush-apple

@arkq arkq Awaiting requested review from arkq

@Byungjoo-Lee Byungjoo-Lee Awaiting requested review from Byungjoo-Lee

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chshu chshu Awaiting requested review from chshu

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@dhrishi dhrishi Awaiting requested review from dhrishi

@electrocucaracha electrocucaracha Awaiting requested review from electrocucaracha

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@gjc13 gjc13 Awaiting requested review from gjc13

@harimau-qirex harimau-qirex Awaiting requested review from harimau-qirex

@harsha-rajendran harsha-rajendran Awaiting requested review from harsha-rajendran

@hawk248 hawk248 Awaiting requested review from hawk248

@isiu-apple isiu-apple Awaiting requested review from isiu-apple

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@jmartinez-silabs jmartinez-silabs Awaiting requested review from jmartinez-silabs

@jtung-apple jtung-apple Awaiting requested review from jtung-apple

@kpschoedel kpschoedel Awaiting requested review from kpschoedel

@lazarkov lazarkov Awaiting requested review from lazarkov

@LuDuda LuDuda Awaiting requested review from LuDuda

@mrjerryjohns mrjerryjohns Awaiting requested review from mrjerryjohns

@mspang mspang Awaiting requested review from mspang

@rgoliver rgoliver Awaiting requested review from rgoliver

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@saurabhst saurabhst Awaiting requested review from saurabhst

@selissia selissia Awaiting requested review from selissia

@tecimovic tecimovic Awaiting requested review from tecimovic

@tehampson tehampson Awaiting requested review from tehampson

@vijs vijs Awaiting requested review from vijs

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@woody-apple woody-apple Awaiting requested review from woody-apple

@xylophone21 xylophone21 Awaiting requested review from xylophone21

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

Assignees
No one assigned
Labels
review - approved security sve cherry pick
Projects
None yet
Milestone
No milestone
3 participants
@tcarmelveilleux @andy31415 @msandstedt